Mercurial > vim
changeset 30970:6d6545c99597 v9.0.0820
patch 9.0.0820: memory leak with empty shell command
Commit: https://github.com/vim/vim/commit/03d6e6f42b0deeb02d52c8a48c14abe431370c1c
Author: Bram Moolenaar <Bram@vim.org>
Date: Sat Oct 29 21:53:08 2022 +0100
patch 9.0.0820: memory leak with empty shell command
Problem: Memory leak with empty shell command.
Solution: Free the empty string.
| author | Bram Moolenaar <Bram@vim.org> |
|---|---|
| date | Wed, 02 Nov 2022 11:18:50 +0100 |
| parents | 1a69f54ebb23 |
| children | 435e8155d5cb |
| files | src/ex_cmds.c src/version.c |
| diffstat | 2 files changed, 8 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/src/ex_cmds.c +++ b/src/ex_cmds.c @@ -957,12 +957,15 @@ do_bang( } } while (trailarg != NULL); - // Don't clear "prevcmd" if there is no command to run. + // Only set "prevcmd" if there is a command to run, otherwise keep te one + // we have. if (STRLEN(newcmd) > 0) { vim_free(prevcmd); prevcmd = newcmd; } + else + free_newcmd = TRUE; if (bangredo) // put cmd in redo buffer for ! command { @@ -986,6 +989,8 @@ do_bang( */ if (*p_shq != NUL) { + if (free_newcmd) + vim_free(newcmd); newcmd = alloc(STRLEN(prevcmd) + 2 * STRLEN(p_shq) + 1); if (newcmd == NULL) return;