# HG changeset patch # User Bram Moolenaar # Date 1667384330 -3600 # Node ID 6d6545c99597482311b0fe8f97e479ce2ec26004 # Parent 1a69f54ebb2362e145bc7c86c865d2a81e876893 patch 9.0.0820: memory leak with empty shell command Commit: https://github.com/vim/vim/commit/03d6e6f42b0deeb02d52c8a48c14abe431370c1c Author: Bram Moolenaar Date: Sat Oct 29 21:53:08 2022 +0100 patch 9.0.0820: memory leak with empty shell command Problem: Memory leak with empty shell command. Solution: Free the empty string. diff --git a/src/ex_cmds.c b/src/ex_cmds.c --- a/src/ex_cmds.c +++ b/src/ex_cmds.c @@ -957,12 +957,15 @@ do_bang( } } while (trailarg != NULL); - // Don't clear "prevcmd" if there is no command to run. + // Only set "prevcmd" if there is a command to run, otherwise keep te one + // we have. if (STRLEN(newcmd) > 0) { vim_free(prevcmd); prevcmd = newcmd; } + else + free_newcmd = TRUE; if (bangredo) // put cmd in redo buffer for ! command { @@ -986,6 +989,8 @@ do_bang( */ if (*p_shq != NUL) { + if (free_newcmd) + vim_free(newcmd); newcmd = alloc(STRLEN(prevcmd) + 2 * STRLEN(p_shq) + 1); if (newcmd == NULL) return; diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -696,6 +696,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 820, +/**/ 819, /**/ 818,