Mercurial > vim

changeset 31865:86ed5031ff2b v9.0.1265

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
patch 9.0.1265: using an interface method may give a compilation error Commit: https://github.com/vim/vim/commit/b8bebd0cd78679162228ee08265c9a5b3a409e1c Author: Bram Moolenaar <Bram@vim.org> Date: Mon Jan 30 20:24:23 2023 +0000 patch 9.0.1265: using an interface method may give a compilation error Problem: Using an interface method may give a compilation error. Solution: Do not try to compile the body of a method of an interface. (closes #11885)
author Bram Moolenaar <Bram@vim.org>
date Mon, 30 Jan 2023 21:30:03 +0100
parents f18ed1684739
children b398a8a9ad05
files src/testdir/test_vim9_class.vim src/version.c src/vim9compile.c
diffstat 3 files changed, 30 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/src/testdir/test_vim9_class.vim
+++ b/src/testdir/test_vim9_class.vim
@@ -1049,6 +1049,23 @@ def Test_call_interface_method()
     unlet g:result
   END
   v9.CheckScriptSuccess(lines)
+
+  # No class that implements the interface.
+  lines =<< trim END
+      vim9script
+
+      interface IWithEE
+          def Enter(): any
+          def Exit(): void
+      endinterface
+
+      def With1(ee: IWithEE, F: func)
+          var r = ee.Enter()
+      enddef
+
+      defcompile
+  END
+  v9.CheckScriptSuccess(lines)
 enddef
 
 def Test_class_used_as_type()
--- a/src/version.c
+++ b/src/version.c
@@ -696,6 +696,8 @@ static char *(features[]) =
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    1265,
+/**/
     1264,
 /**/
     1263,
--- a/src/vim9compile.c
+++ b/src/vim9compile.c
@@ -3181,6 +3181,16 @@ compile_def_function(
     }
     ufunc->uf_args_visible = ufunc->uf_args.ga_len;
 
+    // Compiling a function in an interface is done to get the function type.
+    // No code is actually compiled.
+    if (ufunc->uf_class != NULL
+			   && (ufunc->uf_class->class_flags & CLASS_INTERFACE))
+    {
+	ufunc->uf_def_status = UF_NOT_COMPILED;
+	ret = OK;
+	goto erret;
+    }
+
     /*
      * Loop over all the lines of the function and generate instructions.
      */
@@ -3705,7 +3715,7 @@ nextline:
 	    iemsg("Type stack underflow");
 	    goto erret;
 	}
-    }
+    } // END of the loop over all the function body lines.
 
     if (cctx.ctx_scope != NULL)
     {