Mercurial > vim
changeset 34116:805808a558cf v9.1.0022
patch 9.1.0022: Coverity complains about improper use of negative value
Commit: https://github.com/vim/vim/commit/49471963fefbdf78239d9066d84e14e1876fb177
Author: Christian Brabandt <cb@256bit.org>
Date: Fri Jan 12 17:48:08 2024 +0100
patch 9.1.0022: Coverity complains about improper use of negative value
Problem: Coverity complains about improper use of negative value
Solution: Add a condition to validate that keytyped is larger or equal
to 0
Apparently patch 9.1.0006 made it more explicit for Coverity, that the
TOLOWER_LOC() macros do not handle negative values properly. However,
that condition has always been there even before that, so add a
condition to verify that keytyped is indeed at least 0
closes: #13824
Signed-off-by: Christian Brabandt <cb@256bit.org>
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Fri, 12 Jan 2024 18:00:04 +0100 |
| parents | 8b2a428e4ec9 |
| children | 90c8857fdf3e |
| files | src/cindent.c src/version.c |
| diffstat | 2 files changed, 4 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/src/cindent.c +++ b/src/cindent.c @@ -4108,7 +4108,8 @@ in_cinkeys( } else // TODO: multi-byte - if (keytyped == (int)p[-1] || (icase && keytyped < 256 + if (keytyped == (int)p[-1] || (icase + && keytyped < 256 && keytyped >= 0 && TOLOWER_LOC(keytyped) == TOLOWER_LOC((int)p[-1]))) { line = ml_get_cursor();