Mercurial > vim
changeset 5037:5e0b6a9282df v7.3.1262
updated for version 7.3.1262
Problem: Crash and compilation warnings with Cygwin.
Solution: Check return value of XmbTextListToTextProperty(). Add type casts.
Adjust #ifdefs. (Lech Lorens)
| author | Bram Moolenaar <bram@vim.org> |
|---|---|
| date | Sat, 29 Jun 2013 14:17:02 +0200 |
| parents | 99268315fa88 |
| children | 32db6e075f8f |
| files | src/main.c src/os_unix.c src/ui.c src/version.c |
| diffstat | 4 files changed, 15 insertions(+), 7 deletions(-) [+] |
line wrap: on
line diff
--- a/src/main.c +++ b/src/main.c @@ -2408,7 +2408,7 @@ scripterror: * Look for evidence of non-Cygwin paths before we bother. * This is only for when using the Unix files. */ - if (strpbrk(p, "\\:") != NULL && !path_with_url(p)) + if (vim_strpbrk(p, "\\:") != NULL && !path_with_url(p)) { char posix_path[PATH_MAX]; @@ -2418,7 +2418,7 @@ scripterror: cygwin_conv_to_posix_path(p, posix_path); # endif vim_free(p); - p = vim_strsave(posix_path); + p = vim_strsave((char_u *)posix_path); if (p == NULL) mch_exit(2); }
--- a/src/os_unix.c +++ b/src/os_unix.c @@ -1559,7 +1559,7 @@ x_IOerror_check(dpy) { /* This function should not return, it causes exit(). Longjump instead. */ LONGJMP(lc_jump_env, 1); -# ifdef VMS +# if defined(VMS) || defined(__CYGWIN__) || defined(__CYGWIN32__) return 0; /* avoid the compiler complains about missing return value */ # endif } @@ -1581,7 +1581,7 @@ x_IOerror_handler(dpy) /* This function should not return, it causes exit(). Longjump instead. */ LONGJMP(x_jump_env, 1); -# ifdef VMS +# if defined(VMS) || defined(__CYGWIN__) || defined(__CYGWIN32__) return 0; /* avoid the compiler complains about missing return value */ # endif } @@ -5929,7 +5929,7 @@ mch_expand_wildcards(num_pat, pat, num_f # if defined(__CYGWIN__) || defined(__CYGWIN32__) /* Translate <CR><NL> into <NL>. Caution, buffer may contain NUL. */ p = buffer; - for (i = 0; i < len; ++i) + for (i = 0; i < (int)len; ++i) if (!(buffer[i] == CAR && buffer[i + 1] == NL)) *p++ = buffer[i]; len = p - buffer;
--- a/src/ui.c +++ b/src/ui.c @@ -2366,14 +2366,20 @@ clip_x11_convert_selection_cb(w, sel_ato { XTextProperty text_prop; char *string_nt = (char *)alloc((unsigned)*length + 1); + int conv_result; /* create NUL terminated string which XmbTextListToTextProperty wants */ mch_memmove(string_nt, string, (size_t)*length); string_nt[*length] = NUL; - XmbTextListToTextProperty(X_DISPLAY, (char **)&string_nt, 1, - XCompoundTextStyle, &text_prop); + conv_result = XmbTextListToTextProperty(X_DISPLAY, (char **)&string_nt, + 1, XCompoundTextStyle, &text_prop); vim_free(string_nt); XtFree(*value); /* replace with COMPOUND text */ + if (conv_result != Success) + { + vim_free(string); + return False; + } *value = (XtPointer)(text_prop.value); /* from plain text */ *length = text_prop.nitems; *type = compound_text_atom;