Mercurial > vim

changeset 33808:1774c261d8b1 v9.0.2120

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
patch 9.0.2120: un-used assignment in do_source_buffer_init Commit: https://github.com/vim/vim/commit/4e5c3cf07bfc904b2a558f1d08a7f8a9732ed7db Author: Christian Brabandt <cb@256bit.org> Date: Sun Nov 19 19:06:16 2023 +0100 patch 9.0.2120: un-used assignment in do_source_buffer_init Problem: un-used assignment in do_source_buffer_init Solution: Remove it Coverity warns about assigning NULL to line in scriptfile.c:1408, because right after that assignment, in the next iteration of the loop, line will be overwritten by the next value from vim_strsave(). And in case this was the last iteration, the line variable is no longer used until the function returns. So we can safely remove that assignment. closes: #13547 Signed-off-by: Christian Brabandt <cb@256bit.org>
author Christian Brabandt <cb@256bit.org>
date Tue, 21 Nov 2023 20:15:09 +0100
parents 5b981afc9840
children a309e28289b8
files src/scriptfile.c src/version.c
diffstat 2 files changed, 2 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/src/scriptfile.c
+++ b/src/scriptfile.c
@@ -1405,7 +1405,6 @@ do_source_buffer_init(source_cookie_T *s
 	    goto errret;
 	if (ga_add_string(&sp->buflines, line) == FAIL)
 	    goto errret;
-	line = NULL;
     }
     sp->buf_lnum = 0;
     sp->source_from_buf = TRUE;
--- a/src/version.c
+++ b/src/version.c
@@ -705,6 +705,8 @@ static char *(features[]) =
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    2120,
+/**/
     2119,
 /**/
     2118,