annotate runtime/ftplugin/diff.vim @ 34134:8ae680be2a51

runtime(ftplugin): Use "*" browsefilter pattern to match "All Files" Commit: https://github.com/vim/vim/commit/93197fde0f1db09b1e495cf3eb14a8f42c318b80 Author: Doug Kearns <dougkearns@gmail.com> Date: Sun Jan 14 20:59:02 2024 +0100 runtime(ftplugin): Use "*" browsefilter pattern to match "All Files" Problem: The "*.*" browsefilter pattern only matches all files on Windows (Daryl Lee) Solution: Use "*" to filter on all platforms but keep "*.*" as the label text on Windows. (Fixes #12685, Doug Kearns) The *.* browsefilter pattern used to match "All Files" on Windows is a legacy of the DOS 8.3 filename wildcard matching algorithm. For reasons of backward compatibility this still works on Windows to match all files, even those without an extension. However, this pattern only matches filenames containing a dot on other platforms. This often makes files without an extension difficult to access from the file dialog, e.g., "Makefile" On Windows it is still standard practice to use "*.*" for the filter label so ftplugins should use "All Files (*.*)" on Windows and "All Files (*)" on other platforms. This matches Vim's default browsefilter values. This commit also normalises the browsefilter conditional test to check for the Win32 and GTK GUI features and an unset b:browsefilter. closes: #12759 Signed-off-by: Doug Kearns <dougkearns@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
author Christian Brabandt <cb@256bit.org>
date Sun, 14 Jan 2024 21:15:03 +0100
parents 4027cefc2aab
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
446
7472c565592a updated for version 7.0117
vimboss
parents:
diff changeset
1 " Vim filetype plugin file
7472c565592a updated for version 7.0117
vimboss
parents:
diff changeset
2 " Language: Diff
32770
4027cefc2aab Farewell to Bram and dedicate upcoming Vim 9.1 to him (#12749)
Christian Brabandt <cb@256bit.org>
parents: 26148
diff changeset
3 " Maintainer: The Vim Project <https://github.com/vim/vim>
34134
8ae680be2a51 runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents: 32770
diff changeset
4 " Last Change: 2023 Aug 22
32770
4027cefc2aab Farewell to Bram and dedicate upcoming Vim 9.1 to him (#12749)
Christian Brabandt <cb@256bit.org>
parents: 26148
diff changeset
5 " Former Maintainer: Bram Moolenaar <Bram@vim.org>
446
7472c565592a updated for version 7.0117
vimboss
parents:
diff changeset
6
7472c565592a updated for version 7.0117
vimboss
parents:
diff changeset
7 " Only do this when not done yet for this buffer
7472c565592a updated for version 7.0117
vimboss
parents:
diff changeset
8 if exists("b:did_ftplugin")
7472c565592a updated for version 7.0117
vimboss
parents:
diff changeset
9 finish
7472c565592a updated for version 7.0117
vimboss
parents:
diff changeset
10 endif
7472c565592a updated for version 7.0117
vimboss
parents:
diff changeset
11 let b:did_ftplugin = 1
7472c565592a updated for version 7.0117
vimboss
parents:
diff changeset
12
26148
624439a39432 Update runtime files
Bram Moolenaar <Bram@vim.org>
parents: 21499
diff changeset
13 let b:undo_ftplugin = "setl modeline< commentstring<"
446
7472c565592a updated for version 7.0117
vimboss
parents:
diff changeset
14
7472c565592a updated for version 7.0117
vimboss
parents:
diff changeset
15 " Don't use modelines in a diff, they apply to the diffed file
7472c565592a updated for version 7.0117
vimboss
parents:
diff changeset
16 setlocal nomodeline
21499
3a1ed539ae2a Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents: 446
diff changeset
17
3a1ed539ae2a Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents: 446
diff changeset
18 " If there are comments they start with #
26148
624439a39432 Update runtime files
Bram Moolenaar <Bram@vim.org>
parents: 21499
diff changeset
19 let &l:commentstring = "# %s"
624439a39432 Update runtime files
Bram Moolenaar <Bram@vim.org>
parents: 21499
diff changeset
20
624439a39432 Update runtime files
Bram Moolenaar <Bram@vim.org>
parents: 21499
diff changeset
21 if (has("gui_win32") || has("gui_gtk")) && !exists("b:browsefilter")
34134
8ae680be2a51 runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents: 32770
diff changeset
22 let b:browsefilter = "Diff Files (*.diff)\t*.diff\nPatch Files (*.patch)\t*.h\n"
8ae680be2a51 runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents: 32770
diff changeset
23 if has("win32")
8ae680be2a51 runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents: 32770
diff changeset
24 let b:browsefilter ..= "All Files (*.*)\t*\n"
8ae680be2a51 runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents: 32770
diff changeset
25 else
8ae680be2a51 runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents: 32770
diff changeset
26 let b:browsefilter ..= "All Files (*)\t*\n"
8ae680be2a51 runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents: 32770
diff changeset
27 endif
26148
624439a39432 Update runtime files
Bram Moolenaar <Bram@vim.org>
parents: 21499
diff changeset
28 let b:undo_ftplugin ..= " | unlet! b:browsefilter"
624439a39432 Update runtime files
Bram Moolenaar <Bram@vim.org>
parents: 21499
diff changeset
29 endif