annotate runtime/ftplugin/typescript.vim @ 34134:8ae680be2a51

runtime(ftplugin): Use "*" browsefilter pattern to match "All Files" Commit: https://github.com/vim/vim/commit/93197fde0f1db09b1e495cf3eb14a8f42c318b80 Author: Doug Kearns <dougkearns@gmail.com> Date: Sun Jan 14 20:59:02 2024 +0100 runtime(ftplugin): Use "*" browsefilter pattern to match "All Files" Problem: The "*.*" browsefilter pattern only matches all files on Windows (Daryl Lee) Solution: Use "*" to filter on all platforms but keep "*.*" as the label text on Windows. (Fixes #12685, Doug Kearns) The *.* browsefilter pattern used to match "All Files" on Windows is a legacy of the DOS 8.3 filename wildcard matching algorithm. For reasons of backward compatibility this still works on Windows to match all files, even those without an extension. However, this pattern only matches filenames containing a dot on other platforms. This often makes files without an extension difficult to access from the file dialog, e.g., "Makefile" On Windows it is still standard practice to use "*.*" for the filter label so ftplugins should use "All Files (*.*)" on Windows and "All Files (*)" on other platforms. This matches Vim's default browsefilter values. This commit also normalises the browsefilter conditional test to check for the Win32 and GTK GUI features and an unset b:browsefilter. closes: #12759 Signed-off-by: Doug Kearns <dougkearns@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
author Christian Brabandt <cb@256bit.org>
date Sun, 14 Jan 2024 21:15:03 +0100
parents 0db0640e16e0
children 7c7432a53a6c
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
21825
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
1 " Vim filetype plugin file
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
2 " Language: TypeScript
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
3 " Maintainer: Doug Kearns <dougkearns@gmail.com>
34134
8ae680be2a51 runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents: 21825
diff changeset
4 " Last Change: 2024 Jan 14
21825
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
5
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
6 if exists("b:did_ftplugin")
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
7 finish
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
8 endif
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
9 let b:did_ftplugin = 1
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
10
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
11 let s:cpo_save = &cpo
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
12 set cpo-=C
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
13
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
14 " Set 'formatoptions' to break comment lines but not other lines,
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
15 " and insert the comment leader when hitting <CR> or using "o".
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
16 setlocal formatoptions-=t formatoptions+=croql
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
17
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
18 " Set 'comments' to format dashed lists in comments.
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
19 setlocal comments=sO:*\ -,mO:*\ \ ,exO:*/,s1:/*,mb:*,ex:*/,://
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
20
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
21 setlocal commentstring=//%s
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
22
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
23 setlocal suffixesadd+=.ts,.d.ts,.tsx,.js,.jsx,.cjs,.mjs
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
24
34134
8ae680be2a51 runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents: 21825
diff changeset
25 let b:undo_ftplugin = "setl fo< com< cms< sua<"
8ae680be2a51 runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents: 21825
diff changeset
26
21825
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
27 " Change the :browse e filter to primarily show TypeScript-related files.
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
28 if (has("gui_win32") || has("gui_gtk")) && !exists("b:browsefilter")
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
29 let b:browsefilter="TypeScript Files (*.ts)\t*.ts\n" .
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
30 \ "TypeScript Declaration Files (*.d.ts)\t*.d.ts\n" .
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
31 \ "TSX Files (*.tsx)\t*.tsx\n" .
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
32 \ "JavaScript Files (*.js)\t*.js\n" .
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
33 \ "JavaScript Modules (*.es, *.cjs, *.mjs)\t*.es;*.cjs;*.mjs\n" .
34134
8ae680be2a51 runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents: 21825
diff changeset
34 \ "JSON Files (*.json)\t*.json\n"
8ae680be2a51 runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents: 21825
diff changeset
35 if has("win32")
8ae680be2a51 runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents: 21825
diff changeset
36 let b:browsefilter .= "All Files (*.*)\t*\n"
8ae680be2a51 runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents: 21825
diff changeset
37 else
8ae680be2a51 runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents: 21825
diff changeset
38 let b:browsefilter .= "All Files (*)\t*\n"
8ae680be2a51 runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents: 21825
diff changeset
39 endif
8ae680be2a51 runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents: 21825
diff changeset
40 let b:undo_ftplugin .= " | unlet! b:browsefilter"
21825
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
41 endif
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
42
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
43 let &cpo = s:cpo_save
0db0640e16e0 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
44 unlet s:cpo_save