Mercurial > vim
annotate runtime/ftplugin/jsp.vim @ 34134:8ae680be2a51
runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Commit: https://github.com/vim/vim/commit/93197fde0f1db09b1e495cf3eb14a8f42c318b80
Author: Doug Kearns <dougkearns@gmail.com>
Date: Sun Jan 14 20:59:02 2024 +0100
runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Problem: The "*.*" browsefilter pattern only matches all files on
Windows (Daryl Lee)
Solution: Use "*" to filter on all platforms but keep "*.*" as the label
text on Windows. (Fixes #12685, Doug Kearns)
The *.* browsefilter pattern used to match "All Files" on Windows is a
legacy of the DOS 8.3 filename wildcard matching algorithm. For reasons
of backward compatibility this still works on Windows to match all
files, even those without an extension.
However, this pattern only matches filenames containing a dot on other
platforms. This often makes files without an extension difficult to
access from the file dialog, e.g., "Makefile"
On Windows it is still standard practice to use "*.*" for the filter
label so ftplugins should use "All Files (*.*)" on Windows and "All
Files (*)" on other platforms. This matches Vim's default browsefilter
values.
This commit also normalises the browsefilter conditional test to check
for the Win32 and GTK GUI features and an unset b:browsefilter.
closes: #12759
Signed-off-by: Doug Kearns <dougkearns@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Sun, 14 Jan 2024 21:15:03 +0100 |
parents | c968191a8557 |
children |
rev | line source |
---|---|
7 | 1 " Vim filetype plugin file |
34134
8ae680be2a51
runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents:
28010
diff
changeset
|
2 " Language: jsp |
28010 | 3 " |
4 " This runtime file is looking for a new maintainer. | |
5 " | |
6 " Former maintainer: Dan Sharp | |
34134
8ae680be2a51
runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents:
28010
diff
changeset
|
7 " Last Change: 2009 Jan 20 |
8ae680be2a51
runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents:
28010
diff
changeset
|
8 " 2024 Jan 14 by Vim Project (browsefilter) |
7 | 9 |
10 if exists("b:did_ftplugin") | finish | endif | |
11 | |
12 " Make sure the continuation lines below do not cause problems in | |
13 " compatibility mode. | |
14 let s:save_cpo = &cpo | |
15 set cpo-=C | |
16 | |
17 " Define some defaults in case the included ftplugins don't set them. | |
18 let s:undo_ftplugin = "" | |
19 let s:browsefilter = "Java Files (*.java)\t*.java\n" . | |
34134
8ae680be2a51
runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents:
28010
diff
changeset
|
20 \ "HTML Files (*.html, *.htm)\t*.html;*.htm\n" |
8ae680be2a51
runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents:
28010
diff
changeset
|
21 if has("win32") |
8ae680be2a51
runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents:
28010
diff
changeset
|
22 let s:browsefilter .= "All Files (*.*)\t*\n" |
8ae680be2a51
runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents:
28010
diff
changeset
|
23 else |
8ae680be2a51
runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents:
28010
diff
changeset
|
24 let s:browsefilter .= "All Files (*)\t*\n" |
8ae680be2a51
runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents:
28010
diff
changeset
|
25 endif |
7 | 26 let s:match_words = "" |
27 | |
28 runtime! ftplugin/html.vim ftplugin/html_*.vim ftplugin/html/*.vim | |
29 unlet b:did_ftplugin | |
30 | |
31 " Override our defaults if these were set by an included ftplugin. | |
32 if exists("b:undo_ftplugin") | |
33 let s:undo_ftplugin = b:undo_ftplugin | |
34 unlet b:undo_ftplugin | |
35 endif | |
36 if exists("b:browsefilter") | |
37 let s:browsefilter = b:browsefilter | |
38 unlet b:browsefilter | |
39 endif | |
40 if exists("b:match_words") | |
41 let s:match_words = b:match_words | |
42 unlet b:match_words | |
43 endif | |
44 | |
45 runtime! ftplugin/java.vim ftplugin/java_*.vim ftplugin/java/*.vim | |
46 let b:did_ftplugin = 1 | |
47 | |
48 " Combine the new set of values with those previously included. | |
49 if exists("b:undo_ftplugin") | |
50 let s:undo_ftplugin = b:undo_ftplugin . " | " . s:undo_ftplugin | |
51 endif | |
52 if exists ("b:browsefilter") | |
53 let s:browsefilter = b:browsefilter . s:browsefilter | |
54 endif | |
55 if exists("b:match_words") | |
551 | 56 let s:match_words = b:match_words . ',' . s:match_words |
7 | 57 endif |
58 | |
59 " Load the combined list of match_words for matchit.vim | |
60 if exists("loaded_matchit") | |
61 let b:match_words = s:match_words | |
62 endif | |
63 | |
64 " Change the :browse e filter to primarily show JSP-related files. | |
34134
8ae680be2a51
runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Christian Brabandt <cb@256bit.org>
parents:
28010
diff
changeset
|
65 if (has("gui_win32") || has("gui_gtk")) && !exists("b:browsefilter") |
7 | 66 let b:browsefilter="JSP Files (*.jsp)\t*.jsp\n" . s:browsefilter |
67 endif | |
68 | |
69 " Undo the stuff we changed. | |
70 let b:undo_ftplugin = "unlet! b:browsefilter b:match_words | " . s:undo_ftplugin | |
71 | |
72 " Restore the saved compatibility options. | |
73 let &cpo = s:save_cpo | |
3410
94601b379f38
Updated runtime files. Add Dutch translations.
Bram Moolenaar <bram@vim.org>
parents:
2034
diff
changeset
|
74 unlet s:save_cpo |