Mercurial > vim
changeset 34422:74e92770d59e v9.1.0134
patch 9.1.0134: CI: Test_term_gettitle() is flaky on MacOS 14
Commit: https://github.com/vim/vim/commit/6a46c19b2507bce632b5e67ef31e47e60a95ed10
Author: Christian Brabandt <cb@256bit.org>
Date: Sat Feb 24 15:56:34 2024 +0100
patch 9.1.0134: CI: Test_term_gettitle() is flaky on MacOS 14
Problem: Test_term_gettitle() is flaky on MacOS 14 and Github runners
Solution: Skip the test on Github CI
closes: #14085
It fails with this: '^\\[No Name\\] - VIM\\d*$' does not match 'e] - VIM'
It is not clear why term_gettitle() only get's the last part of the
expected title (perhaps there is a Carriage return in there or the
terminal window is too small?)
So let's just skip this test for now.
Signed-off-by: Christian Brabandt <cb@256bit.org>
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Sat, 24 Feb 2024 16:15:02 +0100 |
| parents | 4c9dbb34c398 |
| children | e98e9dc11b5e |
| files | src/testdir/test_terminal2.vim src/version.c |
| diffstat | 2 files changed, 10 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/src/testdir/test_terminal2.vim +++ b/src/testdir/test_terminal2.vim @@ -535,6 +535,7 @@ func Test_term_getcursor() endfunc " Test for term_gettitle() +" Known to be flaky on Mac-OS X and the GH runners func Test_term_gettitle() " term_gettitle() returns an empty string for a non-terminal buffer " and for a non-existing buffer. @@ -544,6 +545,13 @@ func Test_term_gettitle() if !has('title') || empty(&t_ts) throw "Skipped: can't get/set title" endif + if has('osx') && !empty($CI) && system('uname -m') =~# 'arm64' + " This test often fails with the following error message on Github runners + " MacOS-14 + " '^\\[No Name\\] - VIM\\d*$' does not match 'e] - VIM' + " Why? Is the terminal that runs Vim too small? + throw 'Skipped: FIXME: Running this test on M1 Mac fails on GitHub Actions' + endif let term = term_start([GetVimProg(), '--clean', '-c', 'set noswapfile', '-c', 'set title']) call TermWait(term)