Mercurial > vim
changeset 30942:f55ddd3748f5 v9.0.0805
patch 9.0.0805: filetype autocmd may cause freed memory access
Commit: https://github.com/vim/vim/commit/d0fab10ed2a86698937e3c3fed2f10bd9bb5e731
Author: Bram Moolenaar <Bram@vim.org>
Date: Thu Oct 20 16:03:33 2022 +0100
patch 9.0.0805: filetype autocmd may cause freed memory access
Problem: Filetype autocmd may cause freed memory access.
Solution: Set the quickfix-busy flag while filling the buffer.
| author | Bram Moolenaar <Bram@vim.org> |
|---|---|
| date | Thu, 20 Oct 2022 17:15:04 +0200 |
| parents | 0fe7fc26ec1e |
| children | 60aced971a03 |
| files | src/quickfix.c src/testdir/test_quickfix.vim src/version.c |
| diffstat | 3 files changed, 24 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/src/quickfix.c +++ b/src/quickfix.c @@ -4595,6 +4595,9 @@ qf_update_buffer(qf_info_T *qi, qfline_T qf_winid = win->w_id; } + // autocommands may cause trouble + incr_quickfix_busy(); + if (old_last == NULL) // set curwin/curbuf to buf and save a few things aucmd_prepbuf(&aco, buf); @@ -4616,6 +4619,9 @@ qf_update_buffer(qf_info_T *qi, qfline_T // when the added lines are not visible. if ((win = qf_find_win(qi)) != NULL && old_line_count < win->w_botline) redraw_buf_later(buf, UPD_NOT_VALID); + + // always called after incr_quickfix_busy() + decr_quickfix_busy(); } }
--- a/src/testdir/test_quickfix.vim +++ b/src/testdir/test_quickfix.vim @@ -3455,6 +3455,21 @@ func Test_resize_from_copen() endtry endfunc +func Test_filetype_autocmd() + " this changes the location list while it is in use to fill a buffer + lexpr '' + lopen + augroup FT_loclist + au FileType * call setloclist(0, [], 'f') + augroup END + silent! lolder + lexpr '' + + augroup FT_loclist + au! FileType + augroup END +endfunc + func Test_vimgrep_with_textlock() new @@ -6372,4 +6387,5 @@ func Test_info_line_with_space() call setqflist([], 'f') endfunc + " vim: shiftwidth=2 sts=2 expandtab