Mercurial > vim
changeset 28039:0362ab7c1a02 v8.2.4544
patch 8.2.4544: Coverity warnings for not using returned value
Commit: https://github.com/vim/vim/commit/dbf8094b17781ab1db191cf690e59c79f508a50f
Author: Bram Moolenaar <Bram@vim.org>
Date: Fri Mar 11 14:54:03 2022 +0000
patch 8.2.4544: Coverity warnings for not using returned value
Problem: Coverity warnings for not using returned value.
Solution: Assign to vim_ignored.
| author | Bram Moolenaar <Bram@vim.org> |
|---|---|
| date | Fri, 11 Mar 2022 16:00:03 +0100 |
| parents | 6fe18ea3cfe9 |
| children | aaff721a71c2 |
| files | src/tag.c src/version.c |
| diffstat | 2 files changed, 10 insertions(+), 5 deletions(-) [+] |
line wrap: on
line diff
--- a/src/tag.c +++ b/src/tag.c @@ -2053,7 +2053,7 @@ findtags_get_next_line(findtags_state_T { // Adjust the search file offset to the correct position sinfo_p->curr_offset_used = sinfo_p->curr_offset; - vim_fseek(st->fp, sinfo_p->curr_offset, SEEK_SET); + vim_ignored = vim_fseek(st->fp, sinfo_p->curr_offset, SEEK_SET); eof = vim_fgets(st->lbuf, st->lbuf_size, st->fp); if (!eof && sinfo_p->curr_offset != 0) { @@ -2061,7 +2061,7 @@ findtags_get_next_line(findtags_state_T if (sinfo_p->curr_offset == sinfo_p->high_offset) { // oops, gone a bit too far; try from low offset - vim_fseek(st->fp, sinfo_p->low_offset, SEEK_SET); + vim_ignored = vim_fseek(st->fp, sinfo_p->low_offset, SEEK_SET); sinfo_p->curr_offset = sinfo_p->low_offset; } eof = vim_fgets(st->lbuf, st->lbuf_size, st->fp); @@ -2222,7 +2222,7 @@ findtags_start_state_handler( // not portable). Don't use lseek(), it doesn't work // properly on MacOS Catalina. filesize = vim_ftell(st->fp); - vim_fseek(st->fp, 0L, SEEK_SET); + vim_ignored = vim_fseek(st->fp, 0L, SEEK_SET); // Calculate the first read offset in the file. Start // the search in the middle of the file. @@ -2852,7 +2852,8 @@ line_read_in: if (st->state == TS_STEP_FORWARD) // Seek to the same position to read the same line again - vim_fseek(st->fp, search_info.curr_offset, SEEK_SET); + vim_ignored = vim_fseek(st->fp, search_info.curr_offset, + SEEK_SET); // this will try the same thing again, make sure the offset is // different search_info.curr_offset = 0; @@ -2944,8 +2945,10 @@ findtags_in_file(findtags_state_T *st, c findtags_get_all_tags(st, &margs, buf_ffname); if (st->fp != NULL) + { fclose(st->fp); - st->fp = NULL; + st->fp = NULL; + } #ifdef FEAT_EMACS_TAGS emacs_tags_incstack_free(); #endif