Mercurial > vim
changeset 25901:f48c435bd1df v8.2.3484
patch 8.2.3484: crash when going through spell suggestions
Commit: https://github.com/vim/vim/commit/e275ba4fc994474155fbafe8b87a6d3b477456ba
Author: Bram Moolenaar <Bram@vim.org>
Date: Wed Oct 6 13:41:07 2021 +0100
patch 8.2.3484: crash when going through spell suggestions
Problem: Crash when going through spell suggestions.
Solution: Limit the text length for finding suggestions to the original
length. Do not update buffers when exiting. (closes #8965)
| author | Bram Moolenaar <Bram@vim.org> |
|---|---|
| date | Wed, 06 Oct 2021 14:45:03 +0200 |
| parents | b55afbf97a65 |
| children | 10ad4bc93d66 |
| files | src/clipboard.c src/spellsuggest.c src/testdir/test_spell_utf8.vim src/version.c |
| diffstat | 4 files changed, 25 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/src/clipboard.c +++ b/src/clipboard.c @@ -199,7 +199,8 @@ clip_lose_selection(Clipboard_T *cbd) || get_real_state() == SELECTMODE) && (cbd == &clip_star ? clip_isautosel_star() : clip_isautosel_plus()) - && HL_ATTR(HLF_V) != HL_ATTR(HLF_VNC)) + && HL_ATTR(HLF_V) != HL_ATTR(HLF_VNC) + && !exiting) { update_curbuf(INVERTED_ALL); setcursor();
--- a/src/spellsuggest.c +++ b/src/spellsuggest.c @@ -1178,6 +1178,11 @@ suggest_try_change(suginfo_T *su) p = su->su_badptr + su->su_badlen; (void)spell_casefold(curwin, p, (int)STRLEN(p), fword + n, MAXWLEN - n); + // Make sure the resulting text is not longer than the original text. + n = (int)STRLEN(su->su_badptr); + if (n < MAXWLEN) + fword[n] = NUL; + for (lpi = 0; lpi < curwin->w_s->b_langp.ga_len; ++lpi) { lp = LANGP_ENTRY(curwin->w_s->b_langp, lpi);
--- a/src/testdir/test_spell_utf8.vim +++ b/src/testdir/test_spell_utf8.vim @@ -765,4 +765,20 @@ func Test_spellfile_value() set spellfile=Xdir/Xtest.utf-8.add,Xtest_other.add endfunc +func Test_no_crash_with_weird_text() + new + let lines =<< trim END + r<sfile> + + + + + END + call setline(1, lines) + exe "%norm \<C-v>ez=>\<C-v>wzG" + + bwipe! +endfunc + + " vim: shiftwidth=2 sts=2 expandtab