Mercurial > vim
changeset 22687:73688eec32ca v8.2.1892
patch 8.2.1892: valgrind warns for using uninitialized access in tests
Commit: https://github.com/vim/vim/commit/9c24cd11e2048e16e25271a7a7dbef4593890a18
Author: Bram Moolenaar <Bram@vim.org>
Date: Fri Oct 23 15:40:39 2020 +0200
patch 8.2.1892: valgrind warns for using uninitialized access in tests
Problem: Valgrind warns for using uninitialized access in tests.
Solution: Fix condition for breaking out of loop. (Dominique Pell?,
closes #7187)
| author | Bram Moolenaar <Bram@vim.org> |
|---|---|
| date | Fri, 23 Oct 2020 15:45:04 +0200 |
| parents | 931753494510 |
| children | a4044d94e557 |
| files | src/terminal.c src/version.c |
| diffstat | 2 files changed, 4 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/src/terminal.c +++ b/src/terminal.c @@ -4718,6 +4718,7 @@ f_term_dumpwrite(typval_T *argvars, typv { int c = cell.chars[i]; int pc = prev_cell.chars[i]; + int should_break = c == NUL || pc == NUL; // For the first character NUL is the same as space. if (i == 0) @@ -4727,7 +4728,7 @@ f_term_dumpwrite(typval_T *argvars, typv } if (c != pc) same_chars = FALSE; - if (c == NUL || pc == NUL) + if (should_break) break; } same_attr = vtermAttr2hl(cell.attrs)