changeset 14929:b1df7f99efb7 v8.1.0476

patch 8.1.0476: memory leaks in test_escaped_glob commit https://github.com/vim/vim/commit/a2aad028305c306ecf33e0fd720fe1ed98596371 Author: Bram Moolenaar <Bram@vim.org> Date: Sun Oct 14 22:03:56 2018 +0200 patch 8.1.0476: memory leaks in test_escaped_glob Problem: Memory leaks in test_escaped_glob. Solution: Avoid failure when running the shell, use the sandbox.
author Bram Moolenaar <Bram@vim.org>
date Sun, 14 Oct 2018 22:15:05 +0200
parents 1578ad5a721f
children 15577c6db766
files src/testdir/test_escaped_glob.vim src/version.c
diffstat 2 files changed, 11 insertions(+), 8 deletions(-) [+]
line wrap: on
line diff
--- a/src/testdir/test_escaped_glob.vim
+++ b/src/testdir/test_escaped_glob.vim
@@ -2,8 +2,6 @@
 " characters.
 
 function SetUp()
-  " make sure glob() doesn't use the shell
-  set shell=doesnotexist
   " consistent sorting of file names
   set nofileignorecase
 endfunction
@@ -14,19 +12,22 @@ function Test_glob()
     " filenames. Disable the test on non-Unix systems for now.
     return
   endif
-  call assert_equal("", glob('Xxx\{'))
-  call assert_equal("", glob('Xxx\$'))
+
+  " Execute these commands in the sandbox, so that using the shell fails.
+  " Setting 'shell' to an invalid name causes a memory leak.
+  sandbox call assert_equal("", glob('Xxx\{'))
+  sandbox call assert_equal("", glob('Xxx\$'))
   w! Xxx{
   w! Xxx\$
-  call assert_equal("Xxx{", glob('Xxx\{'))
-  call assert_equal("Xxx$", glob('Xxx\$'))
+  sandbox call assert_equal("Xxx{", glob('Xxx\{'))
+  sandbox call assert_equal("Xxx$", glob('Xxx\$'))
   call delete('Xxx{')
   call delete('Xxx$')
 endfunction
 
 function Test_globpath()
-  call assert_equal("sautest/autoload/globone.vim\nsautest/autoload/globtwo.vim",
+  sandbox call assert_equal("sautest/autoload/globone.vim\nsautest/autoload/globtwo.vim",
         \ globpath('sautest/autoload', 'glob*.vim'))
-  call assert_equal(['sautest/autoload/globone.vim', 'sautest/autoload/globtwo.vim'],
+  sandbox call assert_equal(['sautest/autoload/globone.vim', 'sautest/autoload/globtwo.vim'],
         \ globpath('sautest/autoload', 'glob*.vim', 0, 1))
 endfunction
--- a/src/version.c
+++ b/src/version.c
@@ -793,6 +793,8 @@ static char *(features[]) =
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    476,
+/**/
     475,
 /**/
     474,