changeset 20395:8216bfb88709 v8.2.0752

patch 8.2.0752: terminal in popup window test is a bit flaky Commit: https://github.com/vim/vim/commit/e06a28f5e30f439545ac125d54ffc4e6bd6daada Author: Bram Moolenaar <Bram@vim.org> Date: Wed May 13 23:24:12 2020 +0200 patch 8.2.0752: terminal in popup window test is a bit flaky Problem: Terminal in popup window test is a bit flaky. Solution: Wait for shell job status to be "run". Mark as flaky test.
author Bram Moolenaar <Bram@vim.org>
date Wed, 13 May 2020 23:30:04 +0200
parents 6f6494d0c60e
children 89228c88b5c4
files src/testdir/test_popupwin.vim src/version.c
diffstat 2 files changed, 6 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/src/testdir/test_popupwin.vim
+++ b/src/testdir/test_popupwin.vim
@@ -2422,12 +2422,15 @@ endfunc
 func Test_popupwin_terminal_buffer()
   CheckFeature terminal
   CheckUnix
+  " Starting a terminal to run a shell in is considered flaky.
+  let g:test_is_flaky = 1
 
   let origwin = win_getid()
   let ptybuf = term_start(&shell, #{hidden: 1})
   let winid = popup_create(ptybuf, #{minwidth: 40, minheight: 10})
   " Wait for shell to start
-  sleep 200m
+  call WaitForAssert({-> assert_equal("run", job_status(term_getjob(ptybuf)))})
+  sleep 100m
   " Check this doesn't crash
   call assert_equal(winnr(), winnr('j'))
   call assert_equal(winnr(), winnr('k'))
--- a/src/version.c
+++ b/src/version.c
@@ -747,6 +747,8 @@ static char *(features[]) =
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    752,
+/**/
     751,
 /**/
     750,