Mercurial > vim
changeset 13252:66b8b29854d9 v8.0.1500
patch 8.0.1500: possible NULL pointer dereference
commit https://github.com/vim/vim/commit/0549a1e184d33674f4c2b8fb44ccdf6b9b9808a3
Author: Bram Moolenaar <Bram@vim.org>
Date: Sun Feb 11 15:02:48 2018 +0100
patch 8.0.1500: possible NULL pointer dereference
Problem: Possible NULL pointer dereference. (Coverity)
Solution: Check for the pointer not being NULL.
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Sun, 11 Feb 2018 15:15:06 +0100 |
| parents | 878afef4bf72 |
| children | c921b8a4dca1 |
| files | src/quickfix.c src/version.c |
| diffstat | 2 files changed, 9 insertions(+), 9 deletions(-) [+] |
line wrap: on
line diff
--- a/src/quickfix.c +++ b/src/quickfix.c @@ -3771,7 +3771,7 @@ ex_make(exarg_T *eap) { apply_autocmds(EVENT_QUICKFIXCMDPOST, au_name, curbuf->b_fname, TRUE, curbuf); - if (qi->qf_curlist < qi->qf_listcount) + if (qi != NULL && qi->qf_curlist < qi->qf_listcount) res = qi->qf_lists[qi->qf_curlist].qf_count; else res = 0; @@ -4165,20 +4165,18 @@ ex_cfile(exarg_T *eap) if (res >= 0 && qi != NULL) qf_list_changed(qi, qi->qf_curlist); #ifdef FEAT_AUTOCMD - save_qfid = qi->qf_lists[qi->qf_curlist].qf_id; + if (qi != NULL) + save_qfid = qi->qf_lists[qi->qf_curlist].qf_id; if (au_name != NULL) apply_autocmds(EVENT_QUICKFIXCMDPOST, au_name, NULL, FALSE, curbuf); - /* - * Autocmd might have freed the quickfix/location list. Check whether it is - * still valid - */ - if (!qflist_valid(wp, save_qfid)) + + /* An autocmd might have freed the quickfix/location list. Check whether it + * is still valid. */ + if (qi != NULL && !qflist_valid(wp, save_qfid)) return; #endif if (res > 0 && (eap->cmdidx == CMD_cfile || eap->cmdidx == CMD_lfile)) - { qf_jump(qi, 0, 0, eap->forceit); /* display first error */ - } } /*