# HG changeset patch # User Christian Brabandt # Date 1702396808 -3600 # Node ID 28e1e956f42c9c3b69f7901703125d7e24e5ae91 # Parent 7512223bb93cf9ea969af8279067a37d6dcea6a2 patch 9.0.2159: screenpos() may crash with neg. column Commit: https://github.com/vim/vim/commit/ec54af4e26952d954a4cc009f62c80ea01445d30 Author: zeertzjq Date: Tue Dec 12 16:43:44 2023 +0100 patch 9.0.2159: screenpos() may crash with neg. column Problem: screenpos() may crash with neg. column Solution: validate and correct column closes: #13669 Signed-off-by: zeertzjq Signed-off-by: Christian Brabandt diff --git a/src/move.c b/src/move.c --- a/src/move.c +++ b/src/move.c @@ -1531,6 +1531,8 @@ f_screenpos(typval_T *argvars UNUSED, ty return; } pos.col = tv_get_number(&argvars[2]) - 1; + if (pos.col < 0) + pos.col = 0; pos.coladd = 0; textpos2screenpos(wp, &pos, &row, &scol, &ccol, &ecol); diff --git a/src/testdir/test_cursor_func.vim b/src/testdir/test_cursor_func.vim --- a/src/testdir/test_cursor_func.vim +++ b/src/testdir/test_cursor_func.vim @@ -206,6 +206,11 @@ func Test_screenpos() nmenu WinBar.TEST : call assert_equal(#{col: 1, row: 2, endcol: 1, curscol: 1}, screenpos(win_getid(), 1, 1)) nunmenu WinBar.TEST + call assert_equal(#{col: 1, row: 1, endcol: 1, curscol: 1}, screenpos(win_getid(), 1, 1)) + + call assert_equal(#{col: 0, row: 0, endcol: 0, curscol: 0}, screenpos(0, 0, 1)) + call assert_equal(#{col: 0, row: 0, endcol: 0, curscol: 0}, screenpos(0, -1, 1)) + call assert_equal(#{col: 1, row: 1, endcol: 1, curscol: 1}, screenpos(0, 1, -v:maxcol)) endfunc func Test_screenpos_fold() diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -705,6 +705,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 2159, +/**/ 2158, /**/ 2157,