# HG changeset patch # User Bram Moolenaar # Date 1683648903 -7200 # Node ID 18dd2b5d008c460e8d5a58cfaaf97466d5cdc74f # Parent 0c8925ba7971cdad0bec6313b4ec76eb06df2552 patch 9.0.1531: crash when register contents ends up being invalid Commit: https://github.com/vim/vim/commit/d1ae8366aff286d41e7f5bc513cc0a1af5130aad Author: Bram Moolenaar Date: Tue May 9 17:09:30 2023 +0100 patch 9.0.1531: crash when register contents ends up being invalid Problem: Crash when register contents ends up being invalid. Solution: Check "y_array" is not NULL. diff --git a/src/register.c b/src/register.c --- a/src/register.c +++ b/src/register.c @@ -301,7 +301,7 @@ get_register( if (copy) { // If we run out of memory some or all of the lines are empty. - if (reg->y_size == 0) + if (reg->y_size == 0 || y_current->y_array == NULL) reg->y_array = NULL; else reg->y_array = ALLOC_MULT(char_u *, reg->y_size); diff --git a/src/testdir/test_registers.vim b/src/testdir/test_registers.vim --- a/src/testdir/test_registers.vim +++ b/src/testdir/test_registers.vim @@ -835,6 +835,23 @@ func Test_end_reg_executing() bwipe! endfunc +" This was causing a crash because y_append was ending up being NULL +func Test_zero_y_append() + " Run in a separate Vim instance because changing 'encoding' may cause + " trouble for later tests. + let lines =<< trim END + d + silent ?n + next + so + sil! norm 0V€PSP + set enc=latin1 +   + END + call writefile(lines, 'XTest_zero_y_append', 'D') + call RunVim([], [], '-u NONE -i NONE -e -s -S XTest_zero_y_append -c qa\!') +endfunc + " Make sure that y_append is correctly reset " and the previous register is working as expected func Test_register_y_append_reset() diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -696,6 +696,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 1531, +/**/ 1530, /**/ 1529,