# HG changeset patch # User Bram Moolenaar # Date 1676904303 -3600 # Node ID bb31c1c6d1adfd7e07756019d430231cf2a67525 # Parent c7a3b0bfa44b33d9f4a1f0eb1245cec11cbfcaac patch 9.0.1331: illegal memory access when using :ball in Visual mode Commit: https://github.com/vim/vim/commit/e1121b139480f53d1b06f84f3e4574048108fa0b Author: Pavel Mayorov Date: Mon Feb 20 14:35:20 2023 +0000 patch 9.0.1331: illegal memory access when using :ball in Visual mode Problem: Illegal memory access when using :ball in Visual mode. Solution: Stop Visual mode when using :ball. (Pavel Mayorov, closes https://github.com/vim/vim/issues/11923) diff --git a/src/buffer.c b/src/buffer.c --- a/src/buffer.c +++ b/src/buffer.c @@ -5402,6 +5402,10 @@ ex_buffer_all(exarg_T *eap) else all = TRUE; + // Stop Visual mode, the cursor and "VIsual" may very well be invalid after + // switching to another buffer. + reset_VIsual_and_resel(); + setpcmark(); #ifdef FEAT_GUI diff --git a/src/testdir/test_visual.vim b/src/testdir/test_visual.vim --- a/src/testdir/test_visual.vim +++ b/src/testdir/test_visual.vim @@ -1534,4 +1534,25 @@ func Test_switch_buffer_ends_visual_mode exe 'bwipe!' buf2 endfunc +" Check fix for the heap-based buffer overflow bug found in the function +" utfc_ptr2len and reported at +" https://huntr.dev/bounties/ae933869-a1ec-402a-bbea-d51764c6618e +func Test_heap_buffer_overflow() + enew + set updatecount=0 + + norm R0 + split other + norm R000 + exe "norm \l" + ball + call assert_equal(getpos("."), getpos("v")) + call assert_equal('n', mode()) + norm zW + + %bwipe! + set updatecount& +endfunc + + " vim: shiftwidth=2 sts=2 expandtab diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -696,6 +696,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 1331, +/**/ 1330, /**/ 1329,