# HG changeset patch # User Bram Moolenaar # Date 1661977806 -7200 # Node ID b8abb8908801763ae2ce737cc81157687412b3fa # Parent 0379de231ecdc85215b10ec0b0074591eb7523e6 patch 9.0.0343: ColorScheme autocommand triggered when colorscheme not found Commit: https://github.com/vim/vim/commit/5d09a401ec393dc930e1104ceb38eab34681de64 Author: Bram Moolenaar Date: Wed Aug 31 21:17:10 2022 +0100 patch 9.0.0343: ColorScheme autocommand triggered when colorscheme not found Problem: ColorScheme autocommand triggered when colorscheme is not found. (Romain Lafourcade) Solution: Only trigger ColorScheme when loading the colorscheme succeeds. (closes #11024) diff --git a/src/highlight.c b/src/highlight.c --- a/src/highlight.c +++ b/src/highlight.c @@ -507,7 +507,9 @@ load_colors(char_u *name) sprintf((char *)buf, "colors/%s.vim", name); retval = source_runtime(buf, DIP_START + DIP_OPT); vim_free(buf); - apply_autocmds(EVENT_COLORSCHEME, name, curbuf->b_fname, FALSE, curbuf); + if (retval == OK) + apply_autocmds(EVENT_COLORSCHEME, name, curbuf->b_fname, + FALSE, curbuf); } recursive = FALSE; diff --git a/src/testdir/test_gui.vim b/src/testdir/test_gui.vim --- a/src/testdir/test_gui.vim +++ b/src/testdir/test_gui.vim @@ -36,8 +36,12 @@ func Test_colorscheme() let g:color_count = 0 augroup TestColors au! - au ColorScheme * let g:color_count += 1| let g:after_colors = g:color_count - au ColorSchemePre * let g:color_count += 1 |let g:before_colors = g:color_count + au ColorScheme * let g:color_count += 1 + \ | let g:after_colors = g:color_count + \ | let g:color_after = expand('') + au ColorSchemePre * let g:color_count += 1 + \ | let g:before_colors = g:color_count + \ | let g:color_pre = expand('') augroup END colorscheme torte @@ -45,6 +49,8 @@ func Test_colorscheme() call assert_equal('dark', &background) call assert_equal(1, g:before_colors) call assert_equal(2, g:after_colors) + call assert_equal('torte', g:color_pre) + call assert_equal('torte', g:color_after) call assert_equal("\ntorte", execute('colorscheme')) let a = substitute(execute('hi Search'), "\n\\s\\+", ' ', 'g') @@ -53,6 +59,8 @@ func Test_colorscheme() call assert_match("\nSearch xxx term=reverse ", a) call assert_fails('colorscheme does_not_exist', 'E185:') + call assert_equal('does_not_exist', g:color_pre) + call assert_equal('torte', g:color_after) exec 'colorscheme' colorscheme_saved augroup TestColors diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -708,6 +708,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 343, +/**/ 342, /**/ 341,