# HG changeset patch # User Bram Moolenaar # Date 1659438006 -7200 # Node ID d70f588baaa18d7a230089b21615e7ea1d700e0a # Parent 41a11f07d54d6fd8ea6b046346e9d1265bf9f20d patch 9.0.0134: no test for text property with column zero Commit: https://github.com/vim/vim/commit/f05a1e59a3df759667f2082cf42368945c57e389 Author: Bram Moolenaar Date: Tue Aug 2 11:48:53 2022 +0100 patch 9.0.0134: no test for text property with column zero Problem: No test for text property with column zero. Solution: Add a test. Add message to assert for no open popups. diff --git a/src/testdir/runtest.vim b/src/testdir/runtest.vim --- a/src/testdir/runtest.vim +++ b/src/testdir/runtest.vim @@ -245,7 +245,7 @@ func RunTheTest(test) " Check for and close any stray popup windows. if has('popupwin') - call assert_equal([], popup_list()) + call assert_equal([], popup_list(), 'Popup is still present') call popup_clear(1) endif diff --git a/src/testdir/test_textprop.vim b/src/testdir/test_textprop.vim --- a/src/testdir/test_textprop.vim +++ b/src/testdir/test_textprop.vim @@ -1611,6 +1611,23 @@ func Test_prop_one_line_window() bwipe! endfunc +def Test_prop_column_zero_error() + prop_type_add('proptype', {highlight: 'Search'}) + var caught = false + try + popup_create([{ + text: 'a', + props: [{col: 0, length: 1, type: 'type'}], + }], {}) + catch /E964:/ + caught = true + endtry + assert_true(caught) + + popup_clear() + prop_type_delete('proptype') +enddef + " This was calling ml_append_int() and copy a text property from a previous " line at the wrong moment. Exact text length matters. def Test_prop_splits_data_block() diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -736,6 +736,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 134, +/**/ 133, /**/ 132,