# HG changeset patch
# User Bram Moolenaar <Bram@vim.org>
# Date 1651942803 -7200
# Node ID cf9f5b5c80793f29899247da9b37d0dc2d931a0e
# Parent  c475992c9bee171c798eed566967ace5d40b1f21
patch 8.2.4910: imperfect coding

Commit: https://github.com/vim/vim/commit/9ff7d717aa3176de5c61de340deb93f41c7780fc
Author: Bram Moolenaar <Bram@vim.org>
Date:   Sat May 7 17:45:16 2022 +0100

    patch 8.2.4910: imperfect coding

    Problem:    Imperfect coding.
    Solution:   Make code nicer.

diff --git a/src/ex_getln.c b/src/ex_getln.c
--- a/src/ex_getln.c
+++ b/src/ex_getln.c
@@ -4130,7 +4130,7 @@ get_cmdline_completion(void)
 	return NULL;
 
     p = get_ccline_ptr();
-    if (p && p->xpc != NULL)
+    if (p != NULL && p->xpc != NULL)
     {
 	char_u *cmd_compl;
 
@@ -4138,7 +4138,7 @@ get_cmdline_completion(void)
 
 	cmd_compl = cmdcomplete_type_to_str(p->xpc->xp_context);
 	if (cmd_compl != NULL)
-	    return vim_strnsave(cmd_compl, strlen((char *)cmd_compl));
+	    return vim_strsave(cmd_compl);
     }
 
     return NULL;
diff --git a/src/version.c b/src/version.c
--- a/src/version.c
+++ b/src/version.c
@@ -747,6 +747,8 @@ static char *(features[]) =
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    4910,
+/**/
     4909,
 /**/
     4908,