# HG changeset patch # User Bram Moolenaar # Date 1648220404 -3600 # Node ID c8056de1387912213e1191fe0b1c04c1a9f743b5 # Parent 757e2258c287d88a487ad861c14b0364619aee02 patch 8.2.4625: old Coverity warning for resource leak Commit: https://github.com/vim/vim/commit/90da27b9277d74521202e5c146a09056696898ee Author: Bram Moolenaar Date: Fri Mar 25 14:54:18 2022 +0000 patch 8.2.4625: old Coverity warning for resource leak Problem: Old Coverity warning for resource leak. Solution: Call FreeWild() if expanding matches did not fail. diff --git a/src/help.c b/src/help.c --- a/src/help.c +++ b/src/help.c @@ -947,6 +947,7 @@ helptags_one( FILE *fd_tags; FILE *fd; garray_T ga; + int res; int filecount; char_u **files; char_u *p1, *p2; @@ -965,12 +966,14 @@ helptags_one( STRCPY(NameBuff, dir); STRCAT(NameBuff, "/**/*"); STRCAT(NameBuff, ext); - if (gen_expand_wildcards(1, &NameBuff, &filecount, &files, - EW_FILE|EW_SILENT) == FAIL - || filecount == 0) + res = gen_expand_wildcards(1, &NameBuff, &filecount, &files, + EW_FILE|EW_SILENT); + if (res == FAIL || filecount == 0) { if (!got_int) semsg(_(e_no_match_str_1), NameBuff); + if (res != FAIL) + FreeWild(filecount, files); return; } diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -751,6 +751,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 4625, +/**/ 4624, /**/ 4623,