# HG changeset patch # User Bram Moolenaar # Date 1643561103 -3600 # Node ID 8ed815f061afdd6bba82af0efeb88609adbb36d7 # Parent 976fb709e91d14083c5db13c9adcab1b6c5c3dc0 patch 8.2.4261: accessing invalid memory in a regular expression Commit: https://github.com/vim/vim/commit/679d66c2d21dfe03d0f89b9a818b0aaebb4c3b87 Author: Bram Moolenaar Date: Sun Jan 30 16:42:56 2022 +0000 patch 8.2.4261: accessing invalid memory in a regular expression Problem: Accessing invalid memory when a regular expression checks the Visual area while matching in a string. Solution: Do not try matching the Visual area in a string. diff --git a/src/regexp.c b/src/regexp.c --- a/src/regexp.c +++ b/src/regexp.c @@ -1267,8 +1267,8 @@ reg_match_visual(void) colnr_T cols; colnr_T curswant; - // Check if the buffer is the current buffer. - if (rex.reg_buf != curbuf || VIsual.lnum == 0) + // Check if the buffer is the current buffer and not using a string. + if (rex.reg_buf != curbuf || VIsual.lnum == 0 || rex.reg_maxline == 0) return FALSE; if (VIsual_active) diff --git a/src/testdir/test_help.vim b/src/testdir/test_help.vim --- a/src/testdir/test_help.vim +++ b/src/testdir/test_help.vim @@ -1,6 +1,7 @@ " Tests for :help source check.vim +import './vim9.vim' as v9 func Test_help_restore_snapshot() help @@ -168,5 +169,15 @@ func Test_help_long_argument() endtry endfunc +func Test_help_using_visual_match() + let lines =<< trim END + call setline(1, ' ') + /^ + exe "normal \\" + h5\%V€] + END + call v9.CheckScriptFailure(lines, 'E149:') +endfunc + " vim: shiftwidth=2 sts=2 expandtab diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -751,6 +751,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 4261, +/**/ 4260, /**/ 4259,