# HG changeset patch
# User Bram Moolenaar <Bram@vim.org>
# Date 1608065105 -3600
# Node ID 94608d7c3b55914fb4265c732ea96627a46f0309
# Parent  f26564daf7a8e7954a2d50778c86beaf270c487c
patch 8.2.2146: Vim9: automatic conversion of number to string for dict key

Commit: https://github.com/vim/vim/commit/9987fb0b4b591e6450fb1dfbe8f615f365057f2a
Author: Bram Moolenaar <Bram@vim.org>
Date:   Tue Dec 15 21:41:56 2020 +0100

    patch 8.2.2146: Vim9: automatic conversion of number to string for dict key

    Problem:    Vim9: automatic conversion of number to string for dict key.
    Solution:   Do not convert number to string. (closes https://github.com/vim/vim/issues/7474)

diff --git a/src/dict.c b/src/dict.c
--- a/src/dict.c
+++ b/src/dict.c
@@ -951,6 +951,11 @@ eval_dict(char_u **arg, typval_T *rettv,
 	}
 	if (evaluate)
 	{
+	    if (vim9script && check_for_string(&tvkey) == FAIL)
+	    {
+		clear_tv(&tvkey);
+		goto failret;
+	    }
 	    key = tv_get_string_buf_chk(&tvkey, buf);
 	    if (key == NULL)
 	    {
diff --git a/src/testdir/test_vim9_expr.vim b/src/testdir/test_vim9_expr.vim
--- a/src/testdir/test_vim9_expr.vim
+++ b/src/testdir/test_vim9_expr.vim
@@ -1989,6 +1989,14 @@ def Test_expr7_dict()
 
   CheckDefFailure(['var x = ({'], 'E723:', 2)
   CheckDefExecFailure(['{}[getftype("file")]'], 'E716: Key not present in Dictionary: ""', 1)
+
+  # no automatic conversion from number to string
+  lines =<< trim END
+      var n = 123
+      var d = {[n]: 1}
+  END
+  CheckDefFailure(lines, 'E1012:', 2)
+  CheckScriptFailure(['vim9script'] + lines, 'E928:', 3)
 enddef
 
 def Test_expr7_dict_vim9script()
diff --git a/src/version.c b/src/version.c
--- a/src/version.c
+++ b/src/version.c
@@ -751,6 +751,8 @@ static char *(features[]) =
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    2146,
+/**/
     2145,
 /**/
     2144,