# HG changeset patch # User Bram Moolenaar # Date 1604258103 -3600 # Node ID 3ec5f653f64d53e6d08ac9aad799e2744359400e # Parent a707e11443eea8737b42f371b1afd3526a7d90f6 patch 8.2.1937: Vim9: test for confirm modifier fails in some situations Commit: https://github.com/vim/vim/commit/645cd3eb1fae784579fab11feea634bfaff9af49 Author: Bram Moolenaar Date: Sun Nov 1 20:04:57 2020 +0100 patch 8.2.1937: Vim9: test for confirm modifier fails in some situations Problem: Vim9: test for confirm modifier fails in some situations. Solution: Add a short wait. Handle failure better. diff --git a/src/testdir/term_util.vim b/src/testdir/term_util.vim --- a/src/testdir/term_util.vim +++ b/src/testdir/term_util.vim @@ -147,8 +147,13 @@ func StopVimInTerminal(buf) " Wait for all the pending updates to terminal to complete call TermWait(a:buf) + " Wait for the terminal to end. call WaitForAssert({-> assert_equal("finished", term_getstatus(a:buf))}) - only! + + " If the buffer still exists forcefully wipe it. + if bufexists(a:buf) + exe a:buf .. 'bwipe!' + endif endfunc " Open a terminal with a shell, assign the job to g:job and return the buffer diff --git a/src/testdir/test_vim9_cmd.vim b/src/testdir/test_vim9_cmd.vim --- a/src/testdir/test_vim9_cmd.vim +++ b/src/testdir/test_vim9_cmd.vim @@ -392,10 +392,14 @@ func Test_command_modifier_confirm() call term_sendkeys(buf, ":call Getout()\n") call WaitForAssert({-> assert_match('(Y)es, \[N\]o: ', term_getline(buf, 8))}, 1000) call term_sendkeys(buf, "y") + call WaitForAssert({-> assert_match('(Y)es, \[N\]o: ', term_getline(buf, 8))}, 1000) + call term_sendkeys(buf, "\") + call TermWait(buf) call StopVimInTerminal(buf) call assert_equal(['changed'], readfile('Xfile')) call delete('Xfile') + call delete('.Xfile.swp') " in case Vim was killed call delete('Xconfirmscript') endfunc diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -751,6 +751,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 1937, +/**/ 1936, /**/ 1935,