# HG changeset patch # User Bram Moolenaar # Date 1597783503 -7200 # Node ID c16af87df6543ed6ce5e9dfa685fb7e3613f3864 # Parent 6c27a522a0cb9249edaf828aed7ade538edffff0 patch 8.2.1482: Vim9: crash when using a nested lambda Commit: https://github.com/vim/vim/commit/aeb2bdd0de5ce5b566509dda5ba9ad6f976063b3 Author: Bram Moolenaar Date: Tue Aug 18 22:32:03 2020 +0200 patch 8.2.1482: Vim9: crash when using a nested lambda Problem: Vim9: crash when using a nested lambda. Solution: Do not clear the growarray when not evaluating. Correct pointer when getting the next line. (closes #6731) diff --git a/src/eval.c b/src/eval.c --- a/src/eval.c +++ b/src/eval.c @@ -397,8 +397,10 @@ skip_expr_concatenate( int vim9script = in_vim9script(); garray_T *gap = &evalarg->eval_ga; int save_flags = evalarg == NULL ? 0 : evalarg->eval_flags; - - if (vim9script + int evaluate = evalarg == NULL + ? FALSE : (evalarg->eval_flags & EVAL_EVALUATE); + + if (vim9script && evaluate && (evalarg->eval_cookie != NULL || evalarg->eval_cctx != NULL)) { ga_init2(gap, sizeof(char_u *), 10); @@ -417,7 +419,7 @@ skip_expr_concatenate( if (evalarg != NULL) evalarg->eval_flags = save_flags; - if (vim9script + if (vim9script && evaluate && (evalarg->eval_cookie != NULL || evalarg->eval_cctx != NULL)) { if (evalarg->eval_ga.ga_len == 1) @@ -5425,6 +5427,7 @@ handle_subscript( && (p[2] == '{' || ASCII_ISALPHA(p[2]))))) { *arg = eval_next_line(evalarg); + p = *arg; check_white = FALSE; } diff --git a/src/scriptfile.c b/src/scriptfile.c --- a/src/scriptfile.c +++ b/src/scriptfile.c @@ -1065,7 +1065,8 @@ source_level(void *cookie) } /* - * Return the readahead line. + * Return the readahead line. Note that the pointer may become invalid when + * getting the next line, if it's concatenated with the next one. */ char_u * source_nextline(void *cookie) diff --git a/src/testdir/test_vim9_expr.vim b/src/testdir/test_vim9_expr.vim --- a/src/testdir/test_vim9_expr.vim +++ b/src/testdir/test_vim9_expr.vim @@ -1624,6 +1624,15 @@ def Test_expr7_lambda_vim9script() assert_equal(12, v) END CheckScriptSuccess(lines) + + # nested lambda with line breaks + lines =<< trim END + vim9script + search('"', 'cW', 0, 0, {-> + synstack('.', col('.')) + ->map({_, v -> synIDattr(v, 'name')})->len()}) + END + CheckScriptSuccess(lines) enddef def Test_expr7_dict() diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -755,6 +755,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 1482, +/**/ 1481, /**/ 1480,