# HG changeset patch # User Bram Moolenaar # Date 1594732505 -7200 # Node ID e641f678bdb921c3d4c2df8c14d6fbd00ad9c51e # Parent 0703e225bb7215b6fa7a833960e444607d2edd66 patch 8.2.1207: Vim9: crash in expr test when run in the GUI Commit: https://github.com/vim/vim/commit/7ce85be63b37ab4ec791dde93a380e8a4d8a04dd Author: Bram Moolenaar Date: Tue Jul 14 15:01:05 2020 +0200 patch 8.2.1207: Vim9: crash in expr test when run in the GUI Problem: Vim9: crash in expr test when run in the GUI. Solution: Break out of loop over hashtab also when function got removed and added. diff --git a/src/testdir/test_vim9_expr.vim b/src/testdir/test_vim9_expr.vim --- a/src/testdir/test_vim9_expr.vim +++ b/src/testdir/test_vim9_expr.vim @@ -1563,10 +1563,8 @@ def Test_expr7_method_call() enddef func Test_expr7_trailing_fails() - " Temporarily commented out - somehow crash occurs with too many - " CheckDefFailure calls in the GUI only. - " call CheckDefFailure(['let l = [2]', 'l->{l -> add(l, 8)}'], 'E107') - " call CheckDefFailure(['let l = [2]', 'l->{l -> add(l, 8)} ()'], 'E274') + call CheckDefFailure(['let l = [2]', 'l->{l -> add(l, 8)}'], 'E107') + call CheckDefFailure(['let l = [2]', 'l->{l -> add(l, 8)} ()'], 'E274') endfunc func Test_expr_fails() diff --git a/src/userfunc.c b/src/userfunc.c --- a/src/userfunc.c +++ b/src/userfunc.c @@ -3444,8 +3444,8 @@ ex_function(exarg_T *eap) void ex_defcompile(exarg_T *eap UNUSED) { - long_u ht_used = func_hashtab.ht_used; - int todo = (int)ht_used; + long todo = (long)func_hashtab.ht_used; + int changed = func_hashtab.ht_changed; hashitem_T *hi; ufunc_T *ufunc; @@ -3460,12 +3460,12 @@ ex_defcompile(exarg_T *eap UNUSED) { compile_def_function(ufunc, FALSE, NULL); - if (func_hashtab.ht_used != ht_used) + if (func_hashtab.ht_changed != changed) { - // another function has been defined, need to start over + // a function has been added or removed, need to start over + todo = (long)func_hashtab.ht_used; + changed = func_hashtab.ht_changed; hi = func_hashtab.ht_array; - ht_used = func_hashtab.ht_used; - todo = (int)ht_used; --hi; } } diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -755,6 +755,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 1207, +/**/ 1206, /**/ 1205,