# HG changeset patch # User Bram Moolenaar # Date 1586890804 -7200 # Node ID bdb712c7ecf42f4a2767863049ddd66ec09aca0a # Parent 23656ac9113ce9a118c7247950f854893b965e3a patch 8.2.0579: Coverity warns for unused value Commit: https://github.com/vim/vim/commit/4d5d0dfe9438bd5f2daa41ebbe6ac9a76d165af0 Author: Bram Moolenaar Date: Tue Apr 14 20:56:31 2020 +0200 patch 8.2.0579: Coverity warns for unused value Problem: Coverity warns for unused value. Solution: Change order and use "else if". diff --git a/src/os_unix.c b/src/os_unix.c --- a/src/os_unix.c +++ b/src/os_unix.c @@ -5491,13 +5491,14 @@ mch_job_start(char **argv, job_T *job, j term = getenv("TERM"); #endif // Use 'term' or $TERM if it starts with "xterm", otherwise fall - // back to "xterm". + // back to "xterm" or "xterm-color". if (term == NULL || *term == NUL || STRNCMP(term, "xterm", 5) != 0) { - if (t_colors > 16) + if (t_colors >= 256) + // TODO: should we check this name is supported? + term = "xterm-256color"; + else if (t_colors > 16) term = "xterm-color"; - if (t_colors >= 256) - term = "xterm-256color"; else term = "xterm"; } diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -747,6 +747,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 579, +/**/ 578, /**/ 577,