# HG changeset patch # User Bram Moolenaar # Date 1553433304 -3600 # Node ID 2699db3e4d9dbc97d740814872fc6cafa72e03a1 # Parent 5878e48ded93d4cf7289d141835492560add8251 patch 8.1.1046: the "secure" variable is used inconsistently commit https://github.com/vim/vim/commit/82b033eff82d3ed0da77fd5f5a1c023766acabba Author: Bram Moolenaar Date: Sun Mar 24 14:02:04 2019 +0100 patch 8.1.1046: the "secure" variable is used inconsistently Problem: the "secure" variable is used inconsistently. (Justin M. Keyes) Solution: Set it to one instead of incrementing. diff --git a/src/buffer.c b/src/buffer.c --- a/src/buffer.c +++ b/src/buffer.c @@ -5498,7 +5498,7 @@ chk_modeline( current_sctx.sc_lnum = 0; #endif // Make sure no risky things are executed as a side effect. - ++secure; + secure = 1; retval = do_set(s, OPT_MODELINE | OPT_LOCAL | flags); diff --git a/src/option.c b/src/option.c --- a/src/option.c +++ b/src/option.c @@ -5151,13 +5151,12 @@ do_set( // effects in secure mode. Also when the value was // set with the P_INSECURE flag and is not // completely replaced. - if (secure + if ((opt_flags & OPT_MODELINE) #ifdef HAVE_SANDBOX - || sandbox != 0 -#endif - || (opt_flags & OPT_MODELINE) - || (!value_is_replaced && (*p & P_INSECURE))) - ++secure; + || sandbox != 0 +#endif + || (!value_is_replaced && (*p & P_INSECURE))) + secure = 1; // Handle side effects, and set the global value // for ":set" on local options. Note: when setting diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -776,6 +776,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 1046, +/**/ 1045, /**/ 1044,