# HG changeset patch # User Christian Brabandt # Date 1508409907 -7200 # Node ID 272ecbaf1b4f44c02e3dd053d2d88ed98a1716ed # Parent 456433325479a01d6cac21ab4878cba55e6bbbd0 patch 8.0.1204: a QuitPre autocommand may get the wrong file name commit https://github.com/vim/vim/commit/87ffb5c1a3aa506a1be07af4e794b3753f839dc3 Author: Bram Moolenaar Date: Thu Oct 19 12:37:42 2017 +0200 patch 8.0.1204: a QuitPre autocommand may get the wrong file name Problem: A QuitPre autocommand may get the wrong file name. Solution: Pass the buffer being closed to apply_autocmds(). (Rich Howe) diff --git a/src/ex_docmd.c b/src/ex_docmd.c --- a/src/ex_docmd.c +++ b/src/ex_docmd.c @@ -7224,10 +7224,14 @@ ex_quit(exarg_T *eap) wp = curwin; #ifdef FEAT_AUTOCMD - apply_autocmds(EVENT_QUITPRE, NULL, NULL, FALSE, curbuf); - /* Refuse to quit when locked or when the buffer in the last window is - * being closed (can only happen in autocommands). */ - if (curbuf_locked() || !win_valid(wp) + /* Refuse to quit when locked. */ + if (curbuf_locked()) + return; + apply_autocmds(EVENT_QUITPRE, NULL, NULL, FALSE, wp->w_buffer); + /* Bail out when autocommands closed the window. + * Refuse to quit when the buffer in the last window is being closed (can + * only happen in autocommands). */ + if (!win_valid(wp) || (wp->w_buffer->b_nwindows == 1 && wp->w_buffer->b_locked > 0)) return; #endif diff --git a/src/testdir/test_autocmd.vim b/src/testdir/test_autocmd.vim --- a/src/testdir/test_autocmd.vim +++ b/src/testdir/test_autocmd.vim @@ -779,3 +779,17 @@ func Test_BufLeave_Wipe() " check that bufinfo doesn't contain a pointer to freed memory call test_garbagecollect_now() endfunc + +func Test_QuitPre() + edit Xfoo + let winid = win_getid(winnr()) + split Xbar + au! QuitPre * let g:afile = expand('') + " Close the other window, should be correct. + exe win_id2win(winid) . 'q' + call assert_equal('Xfoo', g:afile) + + unlet g:afile + bwipe Xfoo + bwipe Xbar +endfunc diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -762,6 +762,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 1204, +/**/ 1203, /**/ 1202,