# HG changeset patch # User Christian Brabandt # Date 1503342904 -7200 # Node ID 52eea5b73b2adad0dc93055c8ad00c9070cb2509 # Parent 5040c9c973c9b08fd9584488750f0a6987ddc5d6 patch 8.0.0980: Coverity warning for failing to open /dev/null commit https://github.com/vim/vim/commit/b109bb4e1208753cb286b39992b58126d5aa4ce6 Author: Bram Moolenaar Date: Mon Aug 21 21:07:29 2017 +0200 patch 8.0.0980: Coverity warning for failing to open /dev/null Problem: Coverity warning for failing to open /dev/null. Solution: When /dev/null can't be opened exit the child. diff --git a/src/os_unix.c b/src/os_unix.c --- a/src/os_unix.c +++ b/src/os_unix.c @@ -4340,6 +4340,7 @@ mch_call_shell( # define EXEC_FAILED 122 /* Exit code when shell didn't execute. Don't use 127, some shells use that already */ +# define OPEN_NULL_FAILED 123 /* Exit code if /dev/null can't be opened */ char_u *newcmd; pid_t pid; @@ -5369,7 +5370,14 @@ mch_job_start(char **argv, job_T *job, j } if (use_null_for_in || use_null_for_out || use_null_for_err) + { null_fd = open("/dev/null", O_RDWR | O_EXTRA, 0); + if (null_fd < 0) + { + perror("opening /dev/null failed"); + _exit(OPEN_NULL_FAILED); + } + } if (pty_slave_fd >= 0) { diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -770,6 +770,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 980, +/**/ 979, /**/ 978,