# HG changeset patch # User Bram Moolenaar # Date 1398278621 -7200 # Node ID 00acac0af680c2d8c82db5258474b121a5908926 # Parent 3201f30b23e1ee3bd88dc2f077c4810d57e79faf updated for version 7.4.264 Problem: Can't define a function starting with "g:". Can't assign a funcref to a buffer-local variable. Solution: Skip "g:" at the start of a function name. Don't check for colons when assigning to a variable. diff --git a/src/eval.c b/src/eval.c --- a/src/eval.c +++ b/src/eval.c @@ -21583,7 +21583,6 @@ ex_function(eap) * Get the function name. There are these situations: * func normal function name * "name" == func, "fudi.fd_dict" == NULL - * s:func script-local function name * dict.func new dictionary entry * "name" == NULL, "fudi.fd_dict" set, * "fudi.fd_di" == NULL, "fudi.fd_newkey" == func @@ -21593,6 +21592,8 @@ ex_function(eap) * dict.func existing dict entry that's not a Funcref * "name" == NULL, "fudi.fd_dict" set, * "fudi.fd_di" set, "fudi.fd_newkey" == NULL + * s:func script-local function name + * g:func global function name, same as "func" */ p = eap->arg; name = trans_function_name(&p, eap->skip, 0, &fudi); @@ -22286,7 +22287,8 @@ trans_function_name(pp, skip, flags, fdp } else { - if (lead == 2) /* skip over "s:" */ + /* skip over "s:" and "g:" */ + if (lead == 2 || (lv.ll_name[0] == 'g' && lv.ll_name[1] == ':')) lv.ll_name += 2; len = (int)(end - lv.ll_name); } @@ -22317,17 +22319,16 @@ trans_function_name(pp, skip, flags, fdp else if (!(flags & TFN_INT) && builtin_function(lv.ll_name, len)) { EMSG2(_("E128: Function name must start with a capital or \"s:\": %s"), - lv.ll_name); + start); goto theend; } - if (!skip) + if (!skip && !(flags & TFN_QUIET)) { char_u *cp = vim_strchr(lv.ll_name, ':'); if (cp != NULL && cp < end) { - EMSG2(_("E884: Function name cannot contain a colon: %s"), - lv.ll_name); + EMSG2(_("E884: Function name cannot contain a colon: %s"), start); goto theend; } } diff --git a/src/testdir/test_eval.in b/src/testdir/test_eval.in --- a/src/testdir/test_eval.in +++ b/src/testdir/test_eval.in @@ -144,9 +144,18 @@ endfun :delcommand AR :call garbagecollect(1) :" +:" function name not starting with capital +:try +:func! g:test() +:echo "test" +:endfunc +:catch +:$put =v:exception +:endtry +:" :" function name includes a colon :try -:func! g:test() +:func! b:test() :echo "test" :endfunc :catch @@ -162,6 +171,13 @@ endfun :$put =v:exception :endtry :" +:" function name starting with/without "g:", buffer-local funcref. +:function! g:Foo() +: $put ='called Foo()' +:endfunction +:let b:my_func = function('Foo') +:call b:my_func() +:" :/^start:/+1,$wq! test.out :" vim: et ts=4 isk-=\: fmr=???,??? :call getchar() diff --git a/src/testdir/test_eval.ok b/src/testdir/test_eval.ok index a0d0e458ce28443b40c66fda650fcb9669a6a909..57383be748130aaf7c90ad5ed77978e8374307b1 GIT binary patch literal 10827 zc%02zOK;ma5awCHUUMeA2PZ%Z+mf?wz3{;gISEko(nT*p4w9p!1{6E6m9{~!|9$zI zAt?WZWBI2z0Qu}_d2f~mZI7X&#)Ff~Y1 zpTHFZ!L&xOGz2qwEd{}nTI(6C>C9*FfBJB3yyOt zde05ixzFH=f#H0t^Kx=`SFEpA>l?lk|H^`wt97yCKUUQ@;63uam_Vj3Ayp@2swx#o zOs(%HEvbO%s|4c!bqP5(q2gcLDm~`mYg59D7G0Akj4@M*TjsU};o3PzbewUnEHdESE|U;#N1g%YAUtBv+aqfwm>w2&?)IDQR#; z;(eAxK`^aPFj}mToBP=ken)yRxTwng{G{)%YrlO8+Oo|VgZ;#Go`FM5jqmX{j<^ft zufhzrW2_Z3dOub=cK1cA+V&h)!`)g58r1=Hv0l!oSONy6*`z@X(ygbBV2Qy?C9iop zhwdVWt$$7?l>gy0^4%jSca)4FiS8c>o#IdRf(*XvgRljC_zVLHw#vm zm|@8vn5bc>CUMl5*&Jt9I=Sh${uXgg5K_Z%5FiLsm>eDT7Az&Ws9}g>f@^`3%bmzQ z@HVRjzL^C#om5kDICC;F2fhtd=I^L4*W$U3dfxt{^A?pobLzWQx zwGKB;R64u0x8TzR1GC0d8!^i~O&Y7b1g@Fp%AIqnUt4G3{H(_158%F1pVbvG&6OH` zP(`=rHImv0#AtIu^0ay}IOee~P~s`Mv`1FUHej)=XiVb{WPHS3wCTF^d#Fk`22m`1 zikd!MTc4ye*Q7Ib^tuPsIM4#6TXmm|=ZTHyB?dHoPDz+nv*Bw_7D@dK*RE+pKGL#q zj?F}PuHDL=0)Oy_pC(Kz+N3aDSCZHBrd87> zlIcZ+xLN*9N~j%>-T)Mf&~Wm{bY4l^$gx&cn{--4o_oz}SNimh4k4m1b{BU;1@7v5 z{&Q`iD}Z>@7rI9*fMGc!q znX`@TaOpcC1=b7slsF?p5GqGZVWdB5mcXWPDM-9c7y$-_?KSRrCG-vGvDiu!Q(={T zgvJqJ89eb0OWzqOu+GS*#2Fca5ME9AD_sd}N~(gy+k_Ed*h#&{AFsN<1wXWV5=6fn zZ62X*L>Q7^XzQ9g%zba9z!b8Iq^n^b^za+`o0{0VBmjW zZfNv+0fF<7umCiC>iBEi^gh%4pSXnITWCCdtpKK9tbuYyd?08vvhDI4&(>FJp2cpr z+N^88&gsFc?@96=wL$gF6np-Pxnl6THx8k*Fg%nkrQ;HK14zMY9Am{Hf0NYf1b@v$ z%|V;M51M-LizX78wLp{p8!JR-_6JkxcDvc`qV#96yjP9jGAm2l`F&m89!km4C>;zw zj`-(I#f$ak{zkmX?alpdu@+t9^=8Yj@7K#pywQ=d4ImEw1xWn~=rJGGus@9WUz-iT z&DIYuL%tBTBlbYwC;bt>mp@_QpG3pVvmMX)muf2nVecOQu3-!SW4=;uWZQ@Rki