# HG changeset patch # User Bram Moolenaar # Date 1365761929 -7200 # Node ID c5eab656ec51dc2d40ef6e39194c74af868a4b5e # Parent a079ef0ce00173db42e2f60beee84b5cec71a505 updated for version 7.3.885 Problem: Double free for list and dict in Lua. (Shougo Matsu) Solution: Do not unref list and dict. (Yasuhiro Matsumoto) diff --git a/src/if_lua.c b/src/if_lua.c --- a/src/if_lua.c +++ b/src/if_lua.c @@ -665,13 +665,6 @@ luaV_pushtype(list_T, list, luaV_List) luaV_type_tostring(list, LUAVIM_LIST) static int -luaV_list_gc (lua_State *L) -{ - list_unref(luaV_unbox(L, luaV_List, 1)); - return 0; -} - - static int luaV_list_len (lua_State *L) { list_T *l = luaV_unbox(L, luaV_List, 1); @@ -801,7 +794,6 @@ luaV_list_insert (lua_State *L) static const luaL_Reg luaV_List_mt[] = { {"__tostring", luaV_list_tostring}, - {"__gc", luaV_list_gc}, {"__len", luaV_list_len}, {"__call", luaV_list_call}, {"__index", luaV_list_index}, @@ -830,13 +822,6 @@ luaV_pushtype(dict_T, dict, luaV_Dict) luaV_type_tostring(dict, LUAVIM_DICT) static int -luaV_dict_gc (lua_State *L) -{ - dict_unref(luaV_unbox(L, luaV_Dict, 1)); - return 0; -} - - static int luaV_dict_len (lua_State *L) { dict_T *d = luaV_unbox(L, luaV_Dict, 1); @@ -929,7 +914,6 @@ luaV_dict_newindex (lua_State *L) static const luaL_Reg luaV_Dict_mt[] = { {"__tostring", luaV_dict_tostring}, - {"__gc", luaV_dict_gc}, {"__len", luaV_dict_len}, {"__call", luaV_dict_call}, {"__index", luaV_dict_index}, diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -729,6 +729,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 885, +/**/ 884, /**/ 883,