# HG changeset patch # User Christian Brabandt # Date 1692133203 -7200 # Node ID e98fc0c439aaee45c262f5c3ea6d7c9f433cbd5b # Parent 4e591c4c4fe7644a9bc38fb4ae24ca788b7f5439 patch 9.0.1714: getcompletion() "cmdline" fails after :autocmd Commit: https://github.com/vim/vim/commit/e4c79d36150431ffb97cb8952ec482af2e57f228 Author: zeertzjq Date: Tue Aug 15 22:41:53 2023 +0200 patch 9.0.1714: getcompletion() "cmdline" fails after :autocmd Problem: getcompletion() "cmdline" fails after :autocmd Solution: Use set_cmd_context() instead of set_one_cmd_context(). closes: #12804 Signed-off-by: Christian Brabandt Co-authored-by: zeertzjq diff --git a/src/cmdexpand.c b/src/cmdexpand.c --- a/src/cmdexpand.c +++ b/src/cmdexpand.c @@ -4017,9 +4017,10 @@ f_getcompletion(typval_T *argvars, typva ExpandInit(&xpc); if (STRCMP(type, "cmdline") == 0) { - set_one_cmd_context(&xpc, pat); + int cmdline_len = (int)STRLEN(pat); + set_cmd_context(&xpc, pat, cmdline_len, cmdline_len, FALSE); xpc.xp_pattern_len = (int)STRLEN(xpc.xp_pattern); - xpc.xp_col = (int)STRLEN(pat); + xpc.xp_col = cmdline_len; } else { diff --git a/src/testdir/test_cmdline.vim b/src/testdir/test_cmdline.vim --- a/src/testdir/test_cmdline.vim +++ b/src/testdir/test_cmdline.vim @@ -612,6 +612,8 @@ func Test_getcompletion() call assert_true(index(l, 'taglist(') >= 0) let l = getcompletion('call paint', 'cmdline') call assert_equal([], l) + let l = getcompletion('autocmd BufEnter * map '], l) func T(a, c, p) let g:cmdline_compl_params = [a:a, a:c, a:p] @@ -3498,14 +3500,15 @@ func Test_rulerformat_position() call StopVimInTerminal(buf) endfunc -func Test_usercmd_completion() - let g:complete=[] +func Test_getcompletion_usercmd() command! -nargs=* -complete=command TestCompletion echo - let g:complete = getcompletion('TestCompletion ', 'cmdline') - let a = getcompletion('', 'cmdline') - - call assert_equal(a, g:complete) + + call assert_equal(getcompletion('', 'cmdline'), + \ getcompletion('TestCompletion ', 'cmdline')) + call assert_equal([''], + \ getcompletion('TestCompletion map xp_context == EXPAND_NOTHING) - xp->xp_context = context; return arg; - } if (context == EXPAND_MAPPINGS) return set_context_in_map_cmd(xp, (char_u *)"map", arg, forceit, FALSE, FALSE, CMD_map); diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -696,6 +696,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 1714, +/**/ 1713, /**/ 1712,