# HG changeset patch # User Bram Moolenaar # Date 1630154703 -7200 # Node ID cb0868062915e712621b9ed57553929a4f555603 # Parent aa8b03b0145717984c82f0493871fa4ec6f6a58b patch 8.2.3381: crash when using NULL list with sign functions Commit: https://github.com/vim/vim/commit/5c56da4de8398566ef96122db44ec93e6c2d483a Author: Bram Moolenaar Date: Sat Aug 28 14:42:25 2021 +0200 patch 8.2.3381: crash when using NULL list with sign functions Problem: Crash when using NULL list with sign functions. Solution: Handle a NULL list like an empty list. (issue https://github.com/vim/vim/issues/8260) diff --git a/src/globals.h b/src/globals.h --- a/src/globals.h +++ b/src/globals.h @@ -1902,7 +1902,7 @@ EXTERN int channel_need_redraw INIT(= FA #endif #define FOR_ALL_LIST_ITEMS(l, li) \ - for ((li) = (l)->lv_first; (li) != NULL; (li) = (li)->li_next) + for ((li) = (l) == NULL ? NULL : (l)->lv_first; (li) != NULL; (li) = (li)->li_next) // While executing a regexp and set to OPTION_MAGIC_ON or OPTION_MAGIC_OFF this // overrules p_magic. Otherwise set to OPTION_MAGIC_NOT_SET. diff --git a/src/testdir/test_signs.vim b/src/testdir/test_signs.vim --- a/src/testdir/test_signs.vim +++ b/src/testdir/test_signs.vim @@ -2012,4 +2012,11 @@ func Test_sign_funcs_multi() call delete("Xsign") endfunc +func Test_sign_null_list() + eval test_null_list()->sign_define() + eval test_null_list()->sign_placelist() + eval test_null_list()->sign_undefine() + eval test_null_list()->sign_unplacelist() +endfunc + " vim: shiftwidth=2 sts=2 expandtab diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -756,6 +756,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 3381, +/**/ 3380, /**/ 3379,