# HG changeset patch # User Bram Moolenaar # Date 1649415604 -7200 # Node ID c3a7be75ef1604d8dca411e8158f914af81553de # Parent 953e5ee8ce51b5030bcde59e7216a637fea9bdb4 patch 8.2.4711: when 'insermode' is set :edit from mapping misbehaves Commit: https://github.com/vim/vim/commit/3a56b6d405fc0f1ca928b77382f97d0c552bea64 Author: zeertzjq Date: Fri Apr 8 11:56:14 2022 +0100 patch 8.2.4711: when 'insermode' is set :edit from mapping misbehaves Problem: When 'insermode' is set :edit from mapping misbehaves. Solution: Don't set "need_start_insertmode" when already in Insert mode. (closes #10116) diff --git a/src/ex_cmds.c b/src/ex_cmds.c --- a/src/ex_cmds.c +++ b/src/ex_cmds.c @@ -3182,7 +3182,7 @@ do_ecmd( redraw_curbuf_later(NOT_VALID); // redraw this buffer later } - if (p_im) + if (p_im && (State & INSERT) == 0) need_start_insertmode = TRUE; #ifdef FEAT_AUTOCHDIR diff --git a/src/testdir/test_edit.vim b/src/testdir/test_edit.vim --- a/src/testdir/test_edit.vim +++ b/src/testdir/test_edit.vim @@ -1840,6 +1840,29 @@ func Test_edit_file_no_read_perm() call delete('Xfile') endfunc +" Using :edit without leaving 'insertmode' should not cause Insert mode to be +" re-entered immediately after +func Test_edit_insertmode_ex_edit() + CheckRunVimInTerminal + + let lines =<< trim END + set insertmode noruler + inoremap edit Xfoo + END + call writefile(lines, 'Xtest_edit_insertmode_ex_edit') + + let buf = RunVimInTerminal('-S Xtest_edit_insertmode_ex_edit', #{rows: 6}) + call TermWait(buf, 50) + call assert_match('^-- INSERT --\s*$', term_getline(buf, 6)) + call term_sendkeys(buf, "\\") + call TermWait(buf, 50) + call assert_notmatch('^-- INSERT --\s*$', term_getline(buf, 6)) + + " clean up + call StopVimInTerminal(buf) + call delete('Xtest_edit_insertmode_ex_edit') +endfunc + " Pressing escape in 'insertmode' should beep func Test_edit_insertmode_esc_beeps() new diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -747,6 +747,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 4711, +/**/ 4710, /**/ 4709,