# HG changeset patch # User Bram Moolenaar # Date 1628795703 -7200 # Node ID b85e44974a08e3bee9c6c10992c40bc95ed14354 # Parent 9569ab5f546a9025aac2bcdc7ec6e0ca5efffb35 patch 8.2.3336: behavior of negative index in list change changed Commit: https://github.com/vim/vim/commit/92f05f21afdb8a43581554a252cb2fc050f9e03b Author: Bram Moolenaar Date: Thu Aug 12 21:12:56 2021 +0200 patch 8.2.3336: behavior of negative index in list change changed Problem: Behavior of negative index in list change changed. (Naruhiko Nishino) Solution: Only change it for Vim9 script. (closes #8749) diff --git a/src/list.c b/src/list.c --- a/src/list.c +++ b/src/list.c @@ -1146,15 +1146,19 @@ list_slice_or_index( n1 = len + n1; if (n1 < 0 || n1 >= len) { - // For a range we allow invalid values and return an empty - // list. A list index out of range is an error. + // For a range we allow invalid values and for legacy script return an + // empty list, for Vim9 script start at the first item. + // A list index out of range is an error. if (!range) { if (verbose) semsg(_(e_listidx), (long)n1_arg); return FAIL; } - n1 = n1 < 0 ? 0 : len; + if (in_vim9script()) + n1 = n1 < 0 ? 0 : len; + else + n1 = len; } if (range) { diff --git a/src/testdir/test_listdict.vim b/src/testdir/test_listdict.vim --- a/src/testdir/test_listdict.vim +++ b/src/testdir/test_listdict.vim @@ -42,6 +42,23 @@ func Test_list_slice() let l[:1] += [1, 2] let l[2:] -= [1] call assert_equal([2, 4, 2], l) + + let lines =<< trim END + VAR l = [1, 2] + call assert_equal([1, 2], l[:]) + call assert_equal([2], l[-1 : -1]) + call assert_equal([1, 2], l[-2 : -1]) + END + call CheckLegacyAndVim9Success(lines) + + let l = [1, 2] + call assert_equal([], l[-3 : -1]) + + let lines =<< trim END + var l = [1, 2] + assert_equal([1, 2], l[-3 : -1]) + END + call CheckDefAndScriptSuccess(lines) endfunc " List identity diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -756,6 +756,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 3336, +/**/ 3335, /**/ 3334,