# HG changeset patch # User Bram Moolenaar # Date 1661880603 -7200 # Node ID b2140f61826c4563dcb1ad4c9d31b43b05d802b9 # Parent 72c94ab5403865b0654e8a5408ba792859d11a8a patch 9.0.0332: overwrite check may block BufWriteCmd Commit: https://github.com/vim/vim/commit/9c8f94636b3610b898ffbbd07f6b75866d16cbca Author: zeertzjq Date: Tue Aug 30 18:17:15 2022 +0100 patch 9.0.0332: overwrite check may block BufWriteCmd Problem: Overwrite check may block BufWriteCmd. Solution: Do not use overwrite check when 'buftype' is "acwrite". (closes #11011) diff --git a/src/ex_cmds.c b/src/ex_cmds.c --- a/src/ex_cmds.c +++ b/src/ex_cmds.c @@ -2094,12 +2094,17 @@ check_overwrite( /* * Write to another file or b_flags set or not writing the whole file: * overwriting only allowed with '!'. + * If "other" is FALSE and bt_nofilename(buf) is TRUE, this must be + * writing an "acwrite" buffer to the same file as its b_ffname, and + * buf_write() will only allow writing with BufWriteCmd autocommands, + * so there is no need for an overwrite check. */ if ( (other - || (buf->b_flags & BF_NOTEDITED) - || ((buf->b_flags & BF_NEW) - && vim_strchr(p_cpo, CPO_OVERNEW) == NULL) - || (buf->b_flags & BF_READERR)) + || (!bt_nofilename(buf) + && ((buf->b_flags & BF_NOTEDITED) + || ((buf->b_flags & BF_NEW) + && vim_strchr(p_cpo, CPO_OVERNEW) == NULL) + || (buf->b_flags & BF_READERR)))) && !p_wa && vim_fexists(ffname)) { diff --git a/src/testdir/test_autocmd.vim b/src/testdir/test_autocmd.vim --- a/src/testdir/test_autocmd.vim +++ b/src/testdir/test_autocmd.vim @@ -1922,6 +1922,21 @@ func Test_BufReadCmd() au! BufWriteCmd endfunc +func Test_BufWriteCmd() + autocmd BufWriteCmd Xbufwritecmd let g:written = 1 + new + file Xbufwritecmd + set buftype=acwrite + call mkdir('Xbufwritecmd') + write + " BufWriteCmd should be triggered even if a directory has the same name + call assert_equal(1, g:written) + call delete('Xbufwritecmd', 'd') + unlet g:written + au! BufWriteCmd + bwipe! +endfunc + func SetChangeMarks(start, end) exe a:start .. 'mark [' exe a:end .. 'mark ]' diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -708,6 +708,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 332, +/**/ 331, /**/ 330,