# HG changeset patch # User Bram Moolenaar # Date 1646422203 -3600 # Node ID ac7db4437368ed8b5dc9736cd557f7bf6e9171c9 # Parent 6836d57ae66e367bcd916a3059a794dacdb4a8ca patch 8.2.4504: when there is a partially matching map full map may not work Commit: https://github.com/vim/vim/commit/196c3850dbe95247f7aa1b0000a5cae625a99ef2 Author: Bram Moolenaar Date: Fri Mar 4 19:22:36 2022 +0000 patch 8.2.4504: when there is a partially matching map full map may not work Problem: When there is a partially matching map and modifyOtherKeys is active a full map may not work. Solution: Only simplify modifiers when there is no matching mapping. (closes #8792) diff --git a/src/getchar.c b/src/getchar.c --- a/src/getchar.c +++ b/src/getchar.c @@ -2598,7 +2598,7 @@ handle_mapping( } // If no partly match found, use the longest full match. - if (keylen != KEYLEN_PART_MAP) + if (keylen != KEYLEN_PART_MAP && mp_match != NULL) { mp = mp_match; keylen = mp_match_len; @@ -2643,7 +2643,7 @@ handle_mapping( max_mlen = mlen + 1; } - if ((mp == NULL || max_mlen >= mp_match_len) && keylen != KEYLEN_PART_MAP) + if ((mp == NULL || max_mlen > mp_match_len) && keylen != KEYLEN_PART_MAP) { int save_keylen = keylen; diff --git a/src/testdir/test_termcodes.vim b/src/testdir/test_termcodes.vim --- a/src/testdir/test_termcodes.vim +++ b/src/testdir/test_termcodes.vim @@ -2098,6 +2098,23 @@ func Test_modifyOtherKeys_mapped() set timeoutlen& endfunc +func Test_modifyOtherKeys_ambiguous_mapping() + new + set timeoutlen=10 + map a + map x + call setline(1, 'x') + + " CTRL-J b should have trigger the mapping and then insert "b" + call feedkeys(GetEscCodeCSI27('J', 5) .. "b\", 'Lx!') + call assert_equal('xb', getline(1)) + + unmap + unmap x + set timeoutlen& + bwipe! +endfunc + " Whether Shift-Tab sends "ESC [ Z" or "ESC [ 27 ; 2 ; 9 ~" is unpredictable, " both should work. func Test_modifyOtherKeys_shift_tab() diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -755,6 +755,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 4504, +/**/ 4503, /**/ 4502,