# HG changeset patch # User Bram Moolenaar # Date 1662372904 -7200 # Node ID aa7109fe5bee407d1afa0f9628f3506a41e4b9a3 # Parent b5d880b3529e0648b9ef7c4db4e06a19f70397a5 patch 9.0.0384: Covertity still complains about using return value of getc() Commit: https://github.com/vim/vim/commit/c7d2ff2ca03f1f36544a92cb93300eae06bcd0c0 Author: Bram Moolenaar Date: Mon Sep 5 11:04:14 2022 +0100 patch 9.0.0384: Covertity still complains about using return value of getc() Problem: Covertity still complains about using return value of getc(). Solution: Check for EOF. diff --git a/src/spellfile.c b/src/spellfile.c --- a/src/spellfile.c +++ b/src/spellfile.c @@ -846,7 +846,7 @@ read_region_section(FILE *fd, slang_T *l if (len > MAXREGIONS * 2) return SP_FORMERROR; for (i = 0; i < len; ++i) - lp->sl_regions[i] = c = getc(fd); // + lp->sl_regions[i] = (c = getc(fd)) == EOF ? 0 : c; // lp->sl_regions[len] = NUL; return c == EOF ? SP_TRUNCERROR : 0; } @@ -927,7 +927,7 @@ read_prefcond_section(FILE *fd, slang_T buf[0] = '^'; // always match at one position only p = buf + 1; while (n-- > 0) - *p++ = c = getc(fd); // + *p++ = (c = getc(fd)) == EOF ? 0 : c; // if (c == EOF) break; *p = NUL; @@ -1067,7 +1067,7 @@ read_sal_section(FILE *fd, slang_T *slan // store the char we got while checking for end of sm_lead *p++ = c; for (++i; i < ccnt; ++i) - *p++ = c = getc(fd); // + *p++ = (c = getc(fd)) == EOF ? 0 : c; // *p++ = NUL; // diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -704,6 +704,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 384, +/**/ 383, /**/ 382,