# HG changeset patch
# User Bram Moolenaar <Bram@vim.org>
# Date 1626028204 -7200
# Node ID 658dfd6be868afd506117b42efba08764f506a4a
# Parent  86d819a48d9f3e265c970f34c460e786313085f7
patch 8.2.3151: Vim9: profiling fails if nested function is also profiled

Commit: https://github.com/vim/vim/commit/ffcfddc759e583471a1ed55e0938d042bf68c507
Author: Bram Moolenaar <Bram@vim.org>
Date:   Sun Jul 11 20:22:30 2021 +0200

    patch 8.2.3151: Vim9: profiling fails if nested function is also profiled

    Problem:    Vim9: profiling fails if nested function is also profiled.
    Solution:   Use the compile type from the outer function. (closes https://github.com/vim/vim/issues/8543)

diff --git a/src/testdir/test_vim9_script.vim b/src/testdir/test_vim9_script.vim
--- a/src/testdir/test_vim9_script.vim
+++ b/src/testdir/test_vim9_script.vim
@@ -4190,6 +4190,14 @@ def ProfiledNested()
   Nested()
 enddef
 
+def ProfiledNestedProfiled()
+  var x = 0
+  def Nested(): any
+      return x
+  enddef
+  Nested()
+enddef
+
 " Execute this near the end, profiling doesn't stop until Vim exists.
 " This only tests that it works, not the profiling output.
 def Test_xx_profile_with_lambda()
@@ -4198,8 +4206,17 @@ def Test_xx_profile_with_lambda()
   profile start Xprofile.log
   profile func ProfiledWithLambda
   ProfiledWithLambda()
+
   profile func ProfiledNested
   ProfiledNested()
+
+  # Also profile the nested function.  Use a different function, although the
+  # contents is the same, to make sure it was not already compiled.
+  profile func *
+  ProfiledNestedProfiled()
+
+  profdel func *
+  profile pause
 enddef
 
 " Keep this last, it messes up highlighting.
diff --git a/src/version.c b/src/version.c
--- a/src/version.c
+++ b/src/version.c
@@ -756,6 +756,8 @@ static char *(features[]) =
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    3151,
+/**/
     3150,
 /**/
     3149,
diff --git a/src/vim9compile.c b/src/vim9compile.c
--- a/src/vim9compile.c
+++ b/src/vim9compile.c
@@ -5570,6 +5570,7 @@ compile_nested_function(exarg_T *eap, cc
     char_u	*lambda_name;
     ufunc_T	*ufunc;
     int		r = FAIL;
+    compiletype_T   compile_type;
 
     if (eap->forceit)
     {
@@ -5636,9 +5637,15 @@ compile_nested_function(exarg_T *eap, cc
 	}
     }
 
-    if (func_needs_compiling(ufunc, COMPILE_TYPE(ufunc))
-	    && compile_def_function(ufunc, TRUE, COMPILE_TYPE(ufunc), cctx)
-								       == FAIL)
+    compile_type = COMPILE_TYPE(ufunc);
+#ifdef FEAT_PROFILE
+    // If the outer function is profiled, also compile the nested function for
+    // profiling.
+    if (cctx->ctx_compile_type == CT_PROFILE)
+	compile_type = CT_PROFILE;
+#endif
+    if (func_needs_compiling(ufunc, compile_type)
+	    && compile_def_function(ufunc, TRUE, compile_type, cctx) == FAIL)
     {
 	func_ptr_unref(ufunc);
 	goto theend;
@@ -5647,8 +5654,7 @@ compile_nested_function(exarg_T *eap, cc
 #ifdef FEAT_PROFILE
     // When the outer function is compiled for profiling, the nested function
     // may be called without profiling.  Compile it here in the right context.
-    if (COMPILE_TYPE(ufunc) == CT_PROFILE
-				       && func_needs_compiling(ufunc, CT_NONE))
+    if (compile_type == CT_PROFILE && func_needs_compiling(ufunc, CT_NONE))
 	compile_def_function(ufunc, FALSE, CT_NONE, cctx);
 #endif