# HG changeset patch # User Bram Moolenaar # Date 1610393404 -3600 # Node ID 4cd173b3d5722fc7a242f9012a1a8c79fccd32fd # Parent 166557d5ba68554fe753d8c15d8d2dd33df4bef8 patch 8.2.2330: Vim9: crash when using :trow in a not executed block Commit: https://github.com/vim/vim/commit/9e1d9e3473f852735ffd605a0fa4d224b81a4f0c Author: Bram Moolenaar Date: Mon Jan 11 20:17:34 2021 +0100 patch 8.2.2330: Vim9: crash when using :trow in a not executed block Problem: Vim9: crash when using :trow in a not executed block. Solution: Don't generate the instruction when skipping. (closes https://github.com/vim/vim/issues/7659) diff --git a/src/testdir/test_vim9_script.vim b/src/testdir/test_vim9_script.vim --- a/src/testdir/test_vim9_script.vim +++ b/src/testdir/test_vim9_script.vim @@ -324,7 +324,7 @@ func g:NoSuchFunc() echo 'none' endfunc -def Test_try_catch() +def Test_try_catch_throw() var l = [] try # comment add(l, '1') @@ -558,6 +558,12 @@ def Test_try_catch() assert_equal(411, n) enddef +def Test_throw_skipped() + if 0 + throw dontgethere + endif +enddef + def DeletedFunc(): list return ['delete me'] enddef diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -751,6 +751,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 2330, +/**/ 2329, /**/ 2328, diff --git a/src/vim9compile.c b/src/vim9compile.c --- a/src/vim9compile.c +++ b/src/vim9compile.c @@ -474,8 +474,10 @@ may_generate_2STRING(int offset, cctx_T isn_T *isn; isntype_T isntype = ISN_2STRING; garray_T *stack = &cctx->ctx_type_stack; - type_T **type = ((type_T **)stack->ga_data) + stack->ga_len + offset; - + type_T **type; + + RETURN_OK_IF_SKIP(cctx); + type = ((type_T **)stack->ga_data) + stack->ga_len + offset; switch ((*type)->tt_type) { // nothing to be done @@ -7461,6 +7463,8 @@ compile_throw(char_u *arg, cctx_T *cctx if (compile_expr0(&p, cctx) == FAIL) return NULL; + if (cctx->ctx_skip == SKIP_YES) + return p; if (may_generate_2STRING(-1, cctx) == FAIL) return NULL; if (generate_instr_drop(cctx, ISN_THROW, 1) == NULL)