# HG changeset patch # User Christian Brabandt # Date 1490902205 -7200 # Node ID 2e6a0ea76a0da4f6fce426f424b9ba4a60b6149a # Parent f8690bedf784616ffa8b05744c53f96f5360e2c1 patch 8.0.0526: Coverity complains about possible negative value commit https://github.com/vim/vim/commit/85325f839a14212c7d517a4cb3464c347bfd0c1e Author: Bram Moolenaar Date: Thu Mar 30 21:18:45 2017 +0200 patch 8.0.0526: Coverity complains about possible negative value Problem: Coverity complains about possible negative value. Solution: Check return value of ftell() not to be negative. diff --git a/src/os_unix.c b/src/os_unix.c --- a/src/os_unix.c +++ b/src/os_unix.c @@ -6006,6 +6006,7 @@ mch_expand_wildcards( { int i; size_t len; + long llen; char_u *p; int dir; @@ -6292,9 +6293,13 @@ mch_expand_wildcards( goto notfound; } fseek(fd, 0L, SEEK_END); - len = ftell(fd); /* get size of temp file */ + llen = ftell(fd); /* get size of temp file */ fseek(fd, 0L, SEEK_SET); - buffer = alloc(len + 1); + if (llen < 0) + /* just in case ftell() would fail */ + buffer = NULL; + else + buffer = alloc(llen + 1); if (buffer == NULL) { /* out of memory */ @@ -6303,6 +6308,7 @@ mch_expand_wildcards( fclose(fd); return FAIL; } + len = llen; i = fread((char *)buffer, 1, len, fd); fclose(fd); mch_remove(tempname); diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -765,6 +765,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 526, +/**/ 525, /**/ 524,