Mercurial > vim
view src/installml.sh @ 34686:83875247fbc0 v9.1.0224
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text
Commit: https://github.com/vim/vim/commit/515f734e687f28f7199b2a8042197624d9f3ec15
Author: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Date: Thu Mar 28 12:01:14 2024 +0100
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text
Problem: If a line has "right" & "below" virtual text properties,
where the "below" property may be stored first due to lack of
ordering between them, then the line height is calculated to
be 1 more and causes the cursor to far over the line.
Solution: Remove some unnecessary setting of a
`next_right_goes_below = TRUE` flag for "below" and "above"
text properties. (Dylan Thacker-Smith)
I modified a regression test I recently added to cover this case,
leveraging the fact that "after", "right" & "below" text properties are
being stored in the reverse of the order they are added in. The
previous version of this regression test was crafted to workaround this
issue so it can be addressed by this separate patch.
closes: #14317
Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Thu, 28 Mar 2024 12:15:03 +0100 |
parents | 3f399c28e4af |
children |
line wrap: on
line source
#! /bin/sh # installml.sh --- install or uninstall manpage links for Vim # # arguments: # 1 what: "install" or "uninstall" # 2 also do GUI pages: "yes" or "" # 3 target directory e.g., "/usr/local/man/it/man1" # 4 vim exe name e.g., "vim" # 5 vimdiff exe name e.g., "vimdiff" # 6 evim exe name e.g., "evim" # 7 ex exe name e.g., "ex" # 8 view exe name e.g., "view" # 9 rvim exe name e.g., "rvim" # 10 rview exe name e.g., "rview" # 11 gvim exe name e.g., "gvim" # 12 gview exe name e.g., "gview" # 13 rgvim exe name e.g., "rgvim" # 14 rgview exe name e.g., "rgview" # 15 gvimdiff exe name e.g., "gvimdiff" # 16 eview exe name e.g., "eview" errstatus=0 what=$1 gui=$2 destdir=$3 vimname=$4 vimdiffname=$5 evimname=$6 exname=$7 viewname=$8 rvimname=$9 # old shells don't understand ${10} shift rviewname=$9 shift gvimname=$9 shift gviewname=$9 shift rgvimname=$9 shift rgviewname=$9 shift gvimdiffname=$9 shift eviewname=$9 if test $what = "install" -a \( -f $destdir/$vimname.1 -o -f $destdir/$vimdiffname.1 -o -f $destdir/$eviewname.1 \); then if test ! -d $destdir; then echo creating $destdir /bin/sh install-sh -c -d $destdir fi # ex if test ! -f $destdir/$exname.1 -a -f $destdir/$vimname.1; then echo creating link $destdir/$exname.1 cd $destdir; ln -s $vimname.1 $exname.1 fi # view if test ! -f $destdir/$viewname.1 -a -f $destdir/$vimname.1; then echo creating link $destdir/$viewname.1 cd $destdir; ln -s $vimname.1 $viewname.1 fi # rvim if test ! -f $destdir/$rvimname.1 -a -f $destdir/$vimname.1; then echo creating link $destdir/$rvimname.1 cd $destdir; ln -s $vimname.1 $rvimname.1 fi # rview if test ! -f $destdir/$rviewname.1 -a -f $destdir/$vimname.1; then echo creating link $destdir/$rviewname.1 cd $destdir; ln -s $vimname.1 $rviewname.1 fi # GUI targets are optional if test "$gui" = "yes"; then # gvim if test ! -f $destdir/$gvimname.1 -a -f $destdir/$vimname.1; then echo creating link $destdir/$gvimname.1 cd $destdir; ln -s $vimname.1 $gvimname.1 fi # gview if test ! -f $destdir/$gviewname.1 -a -f $destdir/$vimname.1; then echo creating link $destdir/$gviewname.1 cd $destdir; ln -s $vimname.1 $gviewname.1 fi # rgvim if test ! -f $destdir/$rgvimname.1 -a -f $destdir/$vimname.1; then echo creating link $destdir/$rgvimname.1 cd $destdir; ln -s $vimname.1 $rgvimname.1 fi # rgview if test ! -f $destdir/$rgviewname.1 -a -f $destdir/$vimname.1; then echo creating link $destdir/$rgviewname.1 cd $destdir; ln -s $vimname.1 $rgviewname.1 fi # gvimdiff if test ! -f $destdir/$gvimdiffname.1 -a -f $destdir/$vimdiffname.1; then echo creating link $destdir/$gvimdiffname.1 cd $destdir; ln -s $vimdiffname.1 $gvimdiffname.1 fi # eview if test ! -f $destdir/$eviewname.1 -a -f $destdir/$evimname.1; then echo creating link $destdir/$eviewname.1 cd $destdir; ln -s $evimname.1 $eviewname.1 fi fi fi if test $what = "uninstall"; then echo Checking for Vim manual page links in $destdir... if test -L $destdir/$exname.1; then echo deleting $destdir/$exname.1 rm -f $destdir/$exname.1 fi if test -L $destdir/$viewname.1; then echo deleting $destdir/$viewname.1 rm -f $destdir/$viewname.1 fi if test -L $destdir/$rvimname.1; then echo deleting $destdir/$rvimname.1 rm -f $destdir/$rvimname.1 fi if test -L $destdir/$rviewname.1; then echo deleting $destdir/$rviewname.1 rm -f $destdir/$rviewname.1 fi # GUI targets are optional if test "$gui" = "yes"; then if test -L $destdir/$gvimname.1; then echo deleting $destdir/$gvimname.1 rm -f $destdir/$gvimname.1 fi if test -L $destdir/$gviewname.1; then echo deleting $destdir/$gviewname.1 rm -f $destdir/$gviewname.1 fi if test -L $destdir/$rgvimname.1; then echo deleting $destdir/$rgvimname.1 rm -f $destdir/$rgvimname.1 fi if test -L $destdir/$rgviewname.1; then echo deleting $destdir/$rgviewname.1 rm -f $destdir/$rgviewname.1 fi if test -L $destdir/$gvimdiffname.1; then echo deleting $destdir/$gvimdiffname.1 rm -f $destdir/$gvimdiffname.1 fi if test -L $destdir/$eviewname.1; then echo deleting $destdir/$eviewname.1 rm -f $destdir/$eviewname.1 fi fi fi exit $errstatus # vim: set sw=3 :