patch 9.1.0223: code duplication in loop to add active text properties Commit: https://github.com/vim/vim/commit/1134fdd1b369119d0d6992e3120bb5f7c788b697 Author: Dylan Thacker-Smith <dylan.ah.smith@gmail.com> Date: Thu Mar 28 11:49:46 2024 +0100 patch 9.1.0223: code duplication in loop to add active text properties Problem: There are two dense conditions with duplication that needs to be kept in sync between the while loop break condition and the condition to skip certain text properties. Solution: Refactor the loop by moving while loop conditions into the body of the while loop so they can be shared with skip conditions. `break` and an `active` variable are used to handle the outcome of these merged conditions. (Dylan Thacker-Smith) closes: #14307 Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>

vim9script

# Extra functionality for displaying Vim help .

# Called when editing the doc/syntax.txt file
export def HighlightGroups()
  var save_cursor = getcurpos()
  var buf: number = bufnr('%')

  var start: number = search('\*highlight-groups\*', 'c')
  var end: number = search('^======')
  for lnum in range(start, end)
    var word: string = getline(lnum)->matchstr('^\w\+\ze\t')
    if word->hlexists()
      var type = 'help-hl-' .. word
      if prop_type_list({bufnr: buf})->index(type) != -1
	# was called before, delete existing properties
	prop_remove({type: type, bufnr: buf})
	prop_type_delete(type, {bufnr: buf})
      endif
      prop_type_add(type, {
	bufnr: buf,
	highlight: word,
	combine: false,
	})
      prop_add(lnum, 1, {length: word->strlen(), type: type})
    endif
  endfor

  setpos('.', save_cursor)
enddef