Mercurial > vim
view runtime/bugreport.vim @ 34548:db67c09ccd53 v9.1.0175
patch 9.1.0175: wrong window positions with 'winfix{width,height}'
Commit: https://github.com/vim/vim/commit/5866bc3a0f54115d5982fdc09bdbe4c45069265a
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Wed Mar 13 20:17:24 2024 +0100
patch 9.1.0175: wrong window positions with 'winfix{width,height}'
Problem: winframe functions incorrectly recompute window positions if
the altframe wasn't adjacent to the closed frame, which is
possible if adjacent windows had 'winfix{width,height}' set.
Solution: recompute for windows within the parent of the altframe and
closed frame. Skip this (as before) if the altframe was
top/left, but only if adjacent to the closed frame, as
positions won't change in that case. Also correct the return
value documentation for win_screenpos. (Sean Dewar)
The issue revealed itself after removing the win_comp_pos call below
winframe_restore in win_splitmove. Similarly, wrong positions could result from
windows closed in other tabpages, as win_free_mem uses winframe_remove (at least
until it is entered later, where enter_tabpage calls win_comp_pos).
NOTE: As win_comp_pos handles only curtab, it's possible via other means for
positions in non-current tabpages to be wrong (e.g: after changing 'laststatus',
'showtabline', etc.). Given enter_tabpage recomputes it, maybe it's intentional
as an optimization? Should probably be documented in win_screenpos then, but I
won't address that here.
closes: #14191
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Wed, 13 Mar 2024 20:30:03 +0100 |
| parents | 4027cefc2aab |
| children |
line wrap: on
line source
:" Use this script to create the file "bugreport.txt", which contains :" information about the environment of a possible bug in Vim. :" :" Maintainer: The Vim Project <https://github.com/vim/vim> :" Last change: 2023 Aug 10 :" Former Maintainer: Bram Moolenaar <Bram@vim.org> :" :" To use inside Vim: :" :so $VIMRUNTIME/bugreport.vim :" Or, from the command line: :" vim -s $VIMRUNTIME/bugreport.vim :" :" The "if 1" lines are to avoid error messages when expression evaluation is :" not compiled in. :" :if 1 : let more_save = &more :endif :set nomore :if has("unix") : !echo "uname -a" >bugreport.txt : !uname -a >>bugreport.txt :endif :redir >>bugreport.txt :version :if 1 : func <SID>CheckDir(n) : if isdirectory(a:n) : echo 'directory "' . a:n . '" exists' : else : echo 'directory "' . a:n . '" does NOT exist' : endif : endfun : func <SID>CheckFile(n) : if filereadable(a:n) : echo '"' . a:n . '" is readable' : else : echo '"' . a:n . '" is NOT readable' : endif : endfun : echo "--- Directories and Files ---" : echo '$VIM = "' . $VIM . '"' : call <SID>CheckDir($VIM) : echo '$VIMRUNTIME = "' . $VIMRUNTIME . '"' : call <SID>CheckDir($VIMRUNTIME) : call <SID>CheckFile(&helpfile) : call <SID>CheckFile(fnamemodify(&helpfile, ":h") . "/tags") : call <SID>CheckFile($VIMRUNTIME . "/menu.vim") : call <SID>CheckFile($VIMRUNTIME . "/filetype.vim") : call <SID>CheckFile($VIMRUNTIME . "/syntax/synload.vim") : delfun <SID>CheckDir : delfun <SID>CheckFile : echo "--- Scripts sourced ---" : scriptnames :endif :set all :set termcap :au :if 1 : echo "--- Normal/Visual mode mappings ---" :endif :map :if 1 : echo "--- Insert/Command-line mode mappings ---" :endif :map! :if 1 : echo "--- Abbreviations ---" :endif :ab :if 1 : echo "--- Highlighting ---" :endif :highlight :if 1 : echo "--- Variables ---" :endif :if 1 : let :endif :redir END :set more& :if 1 : let &more = more_save : unlet more_save :endif :e bugreport.txt