view ci/unlisted.make @ 34548:db67c09ccd53 v9.1.0175

patch 9.1.0175: wrong window positions with 'winfix{width,height}' Commit: https://github.com/vim/vim/commit/5866bc3a0f54115d5982fdc09bdbe4c45069265a Author: Sean Dewar <6256228+seandewar@users.noreply.github.com> Date: Wed Mar 13 20:17:24 2024 +0100 patch 9.1.0175: wrong window positions with 'winfix{width,height}' Problem: winframe functions incorrectly recompute window positions if the altframe wasn't adjacent to the closed frame, which is possible if adjacent windows had 'winfix{width,height}' set. Solution: recompute for windows within the parent of the altframe and closed frame. Skip this (as before) if the altframe was top/left, but only if adjacent to the closed frame, as positions won't change in that case. Also correct the return value documentation for win_screenpos. (Sean Dewar) The issue revealed itself after removing the win_comp_pos call below winframe_restore in win_splitmove. Similarly, wrong positions could result from windows closed in other tabpages, as win_free_mem uses winframe_remove (at least until it is entered later, where enter_tabpage calls win_comp_pos). NOTE: As win_comp_pos handles only curtab, it's possible via other means for positions in non-current tabpages to be wrong (e.g: after changing 'laststatus', 'showtabline', etc.). Given enter_tabpage recomputes it, maybe it's intentional as an optimization? Should probably be documented in win_screenpos then, but I won't address that here. closes: #14191 Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
author Christian Brabandt <cb@256bit.org>
date Wed, 13 Mar 2024 20:30:03 +0100
parents e6c291944e18
children
line wrap: on
line source

# vim: ft=make
SHELL = /bin/bash

# List all files that are tracked in git but not listed in Filelist.
# Exit code is 2 ("Make encountered an error") if any such files exist.

# Filelist is a Makefile that defines many variables, so we use Make itself to
# query which variables it defines, then expand them all by wrapping each name
# in $(...), importing Filelist and using $(eval).

include Filelist
$(eval all_patterns := $(shell \
	make -f Filelist --question --print-data-base --no-builtin-rules \
		--no-builtin-variables 2>/dev/null \
	| sed -nre \
		'/^# makefile .from \x27Filelist\x27,/ { \
			n; \
			s/ = .*//; \
			T; \
			s/.*/$$(\0)/; \
			p; \
		}'))

# In Makefile's `prepeare` target, all the IN_README_DIR files are moved from
# READMEdir to the root, so add those files in their Git-tracked location:
all_patterns := $(all_patterns) \
	$(foreach readme, $(IN_README_DIR), READMEdir/$(readme))

# The result 'all_patterns' is a list of patterns (globs), which we expand with
# wildcard to get actual filenames.  Note this means Filelist can list a file
# that does not exist, and it will be omitted at this step.
listed_files := $(wildcard $(all_patterns))

# Default target to actually run the comparison:
.PHONY: check
check:
	@# There are too many files to list on the command line, so we write
	@# that to a temporary file, one per line.
	$(file > Filelist-listed-files)
	$(foreach filename, $(listed_files),\
		$(file >> Filelist-listed-files,$(filename)))
	@# Compare the sorted lists.  Delete that temporary file on both
	@# success and failure, but exit with diff's exit code.
	diff -u0 --label files-in-git <(git ls-files | sort) \
		--label Filelist <(sort --unique Filelist-listed-files); \
	RV=$$?; \
	rm Filelist-listed-files; \
	(($$RV != 0)) && echo "Add files to the right variable in Filelist."; \
	exit $$RV