Mercurial > vim
view runtime/syntax/ld.vim @ 34536:ad6cd802579d v9.1.0170
patch 9.1.0170: Re-allow curwin == prevwin, but document it instead
Commit: https://github.com/vim/vim/commit/d64801e913314d2e19dbb38f60e6d285238debff
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Mar 12 20:46:12 2024 +0100
patch 9.1.0170: Re-allow curwin == prevwin, but document it instead
Problem: more places exist where curwin == prevwin, and it may even be
expected in some cases.
Solution: revert v9.1.0001, but document that it's possible instead.
(Sean Dewar)
I've had a change of heart for the following reasons:
- A quick 'n dirty [GitHub code
search](https://github.com/search?q=%2F%28winnr%5C%28%5C%29%5Cs*%3D%3D%5Cs*winnr%5C%28%5B%27%22%5D%23%5B%27%22%5D%5C%29%7Cwinnr%5C%28%5B%27%22%5D%23%5B%27%22%5D%5C%29%5Cs*%3D%3D%5Cs*winnr%5C%28%5C%29%29%2F&type=code)
reveals some cases where it's expected in the wild.
Particularly, it made me aware `winnr() == winnr('#')` is possible when curwin
is changed temporarily during the evaluation of a &statusline expression item
(`%{...}`), and is used to show something different on the statusline
belonging to the previous window; that behaviour wasn't changed in v9.1.0001,
but it means curwin == prevwin makes sense in some cases.
- The definition and call sites of back_to_prevwin imply some expectation that
prevwin == wp (== curwin) is possible, as it's used to skip entering the
prevwin in that case.
- Prior to v9.1.0001, `:wincmd p` would not beep in the case that was patched in
v9.1.0001, but now does. That resulted in #14047 being opened, as it affected
the CtrlP plugin.
I find it odd that `:wincmd p` had cases where it wouldn't beep despite doing
nothing, but it may be preferable to keep things that way (or instead also
beep if curwin == prevwin, if that's preferred).
- After more digging, I found cases in win_free_mem, enter_tabpage,
aucmd_restbuf and qf_open_new_cwindow where curwin == prevwin is possible
(many of them from autocommands). Others probably exist too, especially in
places where curwin is changed temporarily.
fixes: #14047
closes: #14186
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 12 Mar 2024 21:00:11 +0100 |
parents | b2e8663e6dcc |
children |
line wrap: on
line source
" Vim syntax file " Language: ld(1) script " Previous Maintainer: Nikolai Weibull <now@bitwi.se> " Latest Revision: 2006-04-19 " Last Change: 2023 Apr 19 if exists("b:current_syntax") finish endif let s:cpo_save = &cpo set cpo&vim syn keyword ldTodo contained TODO FIXME XXX NOTE syn region ldComment start='/\*' end='\*/' contains=ldTodo,@Spell syn region ldFileName start=+"+ end=+"+ syn keyword ldPreProc SECTIONS MEMORY OVERLAY PHDRS VERSION INCLUDE syn match ldPreProc '\<VERS_\d\+\.\d\+' syn keyword ldFunction ABSOLUTE ADDR ALIGN BLOCK DATA_SEGMENT_ALIGN \ DATA_SEGMENT_END DATA_SEGMENT_RELRO_END DEFINED \ LOADADDR MAX MIN NEXT SIZEOF SIZEOF_HEADERS \ sizeof_headers syn keyword ldKeyword ENTRY INPUT GROUP OUTPUT \ SEARCH_DIR STARTUP OUTPUT_FORMAT TARGET \ ASSERT EXTERN FORCE_COMMON_ALLOCATION \ INHIBIT_COMMON_ALLOCATION NOCROSSREFS OUTPUT_ARCH \ PROVIDE EXCLUDE_FILE SORT KEEP FILL \ CREATE_OBJECT_SYMBOLS CONSTRUCTORS SUBALIGN \ FILEHDR AT __asm__ ABSOLUTE syn keyword ldDataType BYTE SHORT LONG QUAD SQUAD syn keyword ldOutputType NOLOAD DSECT COPY INFO OVERLAY syn keyword ldPTType PT_NULL PT_LOAD PT_DYNAMIC PT_INTERP \ PT_NOTE PT_SHLIB PT_PHDR syn keyword ldSpecial COMMON syn match ldSpecial '/DISCARD/' syn keyword ldIdentifier ORIGIN LENGTH syn match ldSpecSections '\.' syn match ldSections '\.[^ \t)]\+' syn match ldSpecSections '\.\%(text\|data\|bss\|symver\)\>' syn match ldNumber display '\<0[xX]\x\+\>' syn match ldNumber display '\d\+[KM]\>' contains=ldNumberMult syn match ldNumberMult display '\(\d\+\)\@<=[KM]\>' syn match ldOctal contained display '\<0\o\+\>' \ contains=ldOctalZero syn match ldOctalZero contained display '\<0' syn match ldOctalError contained display '\<0\o*[89]\d*\>' hi def link ldTodo Todo hi def link ldComment Comment hi def link ldFileName String hi def link ldPreProc PreProc hi def link ldFunction Identifier hi def link ldKeyword Keyword hi def link ldType Type hi def link ldDataType ldType hi def link ldOutputType ldType hi def link ldPTType ldType hi def link ldSpecial Special hi def link ldIdentifier Identifier hi def link ldSections Constant hi def link ldSpecSections Special hi def link ldNumber Number hi def link ldNumberMult PreProc hi def link ldOctal ldNumber hi def link ldOctalZero PreProc hi def link ldOctalError Error let b:current_syntax = "ld" let &cpo = s:cpo_save unlet s:cpo_save